From: Dan Carpenter <dan.carpenter@oracle.com>
To: Dimitri Sivanich <sivanich@sgi.com>
Cc: Robin Holt <holt@sgi.com>,
linux-kernel@vger.kernel.org, kernel-janitors@vger.kernel.org,
walter harms <wharms@bfs.de>
Subject: [patch v2] gru: info leak in gru_get_config_info()
Date: Sun, 21 Apr 2013 20:01:07 +0300 [thread overview]
Message-ID: <20130421170107.GA16118@elgon.mountain> (raw)
In-Reply-To: <20130421131902.GT3658@sgi.com>
The "info.fill" array isn't initialized so it can leak uninitialized
stack information to user space.
Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
---
v2: style changes
diff --git a/drivers/misc/sgi-gru/grufile.c b/drivers/misc/sgi-gru/grufile.c
index 44d273c..0535d1e 100644
--- a/drivers/misc/sgi-gru/grufile.c
+++ b/drivers/misc/sgi-gru/grufile.c
@@ -172,6 +172,7 @@ static long gru_get_config_info(unsigned long arg)
nodesperblade = 2;
else
nodesperblade = 1;
+ memset(&info, 0, sizeof(info));
info.cpus = num_online_cpus();
info.nodes = num_online_nodes();
info.blades = info.nodes / nodesperblade;
next prev parent reply other threads:[~2013-04-21 17:01 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-04-21 11:10 [patch] gru: info leak in gru_get_config_info() Dan Carpenter
2013-04-21 11:56 ` walter harms
2013-04-21 13:19 ` Robin Holt
2013-04-21 17:01 ` Dan Carpenter [this message]
2013-04-21 17:33 ` [patch v2] " Dimitri Sivanich
2013-04-22 16:41 ` Robin Holt
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20130421170107.GA16118@elgon.mountain \
--to=dan.carpenter@oracle.com \
--cc=holt@sgi.com \
--cc=kernel-janitors@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=sivanich@sgi.com \
--cc=wharms@bfs.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox