From: Ingo Molnar <mingo@kernel.org>
To: Kees Cook <keescook@chromium.org>
Cc: "H. Peter Anvin" <hpa@zytor.com>,
LKML <linux-kernel@vger.kernel.org>,
"x86@kernel.org" <x86@kernel.org>,
"kernel-hardening@lists.openwall.com"
<kernel-hardening@lists.openwall.com>,
Thomas Gleixner <tglx@linutronix.de>,
Ingo Molnar <mingo@redhat.com>,
David Woodhouse <David.Woodhouse@intel.com>,
Jiri Kosina <jkosina@suse.cz>, Olaf Hering <olaf@aepfle.de>,
Yinghai Lu <yinghai@kernel.org>,
Matt Fleming <matt.fleming@intel.com>,
Gokul Caushik <caushik1@gmail.com>,
Josh Triplett <josh@joshtriplett.org>,
Joe Millenbach <jmillenbach@gmail.com>,
Alexander Duyck <alexander.h.duyck@intel.com>,
Jacob Shin <jacob.shin@amd.com>,
Pekka Enberg <penberg@kernel.org>,
Eric Northup <digitaleric@google.com>,
Dan Rosenberg <drosenberg@vsecurity.com>,
Julien Tinnes <jln@google.com>, Will Drewry <wad@chromium.org>
Subject: Re: [PATCH] x86: kaslr: move ELF relocation handling to C
Date: Mon, 22 Apr 2013 10:04:19 +0200 [thread overview]
Message-ID: <20130422080419.GB7080@gmail.com> (raw)
In-Reply-To: <CAGXu5jKFSmBTQ5Ay+MypkAStvDMrkWMNHCz4XGyy4bVjyVAnHg@mail.gmail.com>
* Kees Cook <keescook@chromium.org> wrote:
> On Sun, Apr 21, 2013 at 2:13 AM, Ingo Molnar <mingo@kernel.org> wrote:
> >
> > * Kees Cook <keescook@chromium.org> wrote:
> >
> >> Moves the relocation handling into C, after decompression. Only
> >> kernels that need relocation support will use the code. The new
> >> CONFIG_RANDOMIZE_BASE does not yet do anything except turn on this logic
> >> for 64-bit kernels.
> >
> > So why not keep the inactive CONFIG_RANDOMIZE_BASE hunks in a separate
> > patch, and just have this one clean, orthogonal patch that moves
> > relocation handling into C?
>
> I had wanted there to be a way to test building with 64-bit
> relocations. With this patch and CONFIG_RANDOMIZE_BASE=y, I could do
> that. Would you rather I remove those pieces?
But AFAICS CONFIG_RANDOMIZE_BASE is not an interactive config option, so
how did you turn it on?
But no strong objections in any case.
Thanks,
Ingo
next prev parent reply other threads:[~2013-04-22 8:04 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-04-19 23:16 [PATCH] x86: kaslr: move ELF relocation handling to C Kees Cook
2013-04-21 9:13 ` Ingo Molnar
2013-04-21 19:46 ` Kees Cook
2013-04-22 8:04 ` Ingo Molnar [this message]
2013-04-22 17:59 ` Kees Cook
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20130422080419.GB7080@gmail.com \
--to=mingo@kernel.org \
--cc=David.Woodhouse@intel.com \
--cc=alexander.h.duyck@intel.com \
--cc=caushik1@gmail.com \
--cc=digitaleric@google.com \
--cc=drosenberg@vsecurity.com \
--cc=hpa@zytor.com \
--cc=jacob.shin@amd.com \
--cc=jkosina@suse.cz \
--cc=jln@google.com \
--cc=jmillenbach@gmail.com \
--cc=josh@joshtriplett.org \
--cc=keescook@chromium.org \
--cc=kernel-hardening@lists.openwall.com \
--cc=linux-kernel@vger.kernel.org \
--cc=matt.fleming@intel.com \
--cc=mingo@redhat.com \
--cc=olaf@aepfle.de \
--cc=penberg@kernel.org \
--cc=tglx@linutronix.de \
--cc=wad@chromium.org \
--cc=x86@kernel.org \
--cc=yinghai@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox