From: "Paul E. McKenney" <paulmck@linux.vnet.ibm.com>
To: Borislav Petkov <bp@alien8.de>
Cc: Ingo Molnar <mingo@kernel.org>, x86-ml <x86@kernel.org>,
lkml <linux-kernel@vger.kernel.org>,
tiwai@suse.de, Thomas Gleixner <tglx@linutronix.de>
Subject: Re: irq 16: nobody cared
Date: Mon, 22 Apr 2013 06:16:44 -0700 [thread overview]
Message-ID: <20130422131644.GH3509@linux.vnet.ibm.com> (raw)
In-Reply-To: <20130422091847.GB4637@pd.tnic>
On Mon, Apr 22, 2013 at 11:18:47AM +0200, Borislav Petkov wrote:
> On Mon, Apr 22, 2013 at 10:01:36AM +0200, Ingo Molnar wrote:
> > Hm, this really smells like a workaround: treating the symptom, not
> > the cause.
>
> Well, I just tested Takashi's add missing synchronize_irq() to the
> suspend path of snd_hda_intel and it doesn't help.
>
> So it could be an issue with this driver or only this hw/driver can
> exacerbate RCU this much to trigger the spurious irq machinery.
>
> > How can an increase in grace-periods break drivers and suspend? Do we
> > understand exactly what happens there?
>
> I'd rather look into Paul's direction here. :)
I believe that we need both -- a fix that prevents the stray irq for
normal CONFIG_RCU_FAST_NO_HZ grace periods and also expediting grace
periods during suspend/resume. I am greedy that way. ;-)
Thanx, Paul
> > If we do, can we fix that instead of tweaking the RCU timeouts?
>
> Well, I was under the impression yesterday that we actually want
> to switch to expedited grace periods for suspend/resume *anyway*,
> regardless of drivers.
>
> Paul?
>
> --
> Regards/Gruss,
> Boris.
>
> Sent from a fat crate under my desk. Formatting is fine.
> --
>
next prev parent reply other threads:[~2013-04-22 13:17 UTC|newest]
Thread overview: 31+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-04-20 18:53 irq 16: nobody cared Borislav Petkov
2013-04-20 23:52 ` Paul E. McKenney
2013-04-21 10:34 ` Borislav Petkov
2013-04-21 16:30 ` Paul E. McKenney
2013-04-21 16:56 ` Borislav Petkov
2013-04-21 18:10 ` Borislav Petkov
2013-04-21 18:56 ` Paul E. McKenney
2013-04-21 19:06 ` Borislav Petkov
2013-04-21 20:34 ` Paul E. McKenney
2013-04-21 20:51 ` Borislav Petkov
2013-04-21 21:42 ` Borislav Petkov
2013-04-21 22:00 ` Paul E. McKenney
2013-04-21 22:12 ` Borislav Petkov
2013-04-22 8:01 ` Ingo Molnar
2013-04-22 9:18 ` Borislav Petkov
2013-04-22 13:16 ` Paul E. McKenney [this message]
2013-04-21 18:47 ` Paul E. McKenney
2013-04-22 8:32 ` Takashi Iwai
2013-04-22 9:13 ` Borislav Petkov
2013-04-22 9:19 ` Takashi Iwai
2013-04-22 10:06 ` Borislav Petkov
2013-04-22 11:33 ` Takashi Iwai
2013-04-22 13:56 ` Borislav Petkov
2013-04-22 12:56 ` Thomas Gleixner
2013-04-22 14:23 ` Borislav Petkov
2013-04-22 14:44 ` Paul E. McKenney
2013-04-22 21:33 ` Borislav Petkov
2013-04-22 22:07 ` Paul E. McKenney
2013-04-23 14:10 ` Thomas Gleixner
2013-04-23 14:34 ` Borislav Petkov
2013-04-23 15:01 ` Paul E. McKenney
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20130422131644.GH3509@linux.vnet.ibm.com \
--to=paulmck@linux.vnet.ibm.com \
--cc=bp@alien8.de \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@kernel.org \
--cc=tglx@linutronix.de \
--cc=tiwai@suse.de \
--cc=x86@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox