From: Arnd Bergmann <arnd@arndb.de>
To: "Lars-Peter Clausen" <lars@metafoo.de>
Cc: Vinod Koul <vinod.koul@intel.com>, Jon Hunter <jon-hunter@ti.com>,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH 2/2] dma: of: Remove check on always true condition
Date: Mon, 22 Apr 2013 14:38:29 +0200 [thread overview]
Message-ID: <201304221438.29857.arnd@arndb.de> (raw)
In-Reply-To: <1366619613-30639-2-git-send-email-lars@metafoo.de>
On Monday 22 April 2013, Lars-Peter Clausen wrote:
> Both of_dma_nbcells field of the of_dma_controller and the args_count field of
> the dma_spec are initialized by parsing the #dma-cells attribute of their device
> tree node. So if the device tree nodes of a DMA controller and the dma_spec
> match this means that of_dma_nbcells and args_count will also match. So the
> second test in the of_dma_find_controller loop is redundant because given the
> first test yields true the second test will also yield true. So we can safely
> remove the test whether of_dma_nbcells matches args_count. Since this was the
> last user of the of_dma_nbcells field we can remove it altogether.
>
> Signed-off-by: Lars-Peter Clausen <lars@metafoo.de>
> ---
Acked-by: Arnd Bergmann <arnd@arndb.de>
next prev parent reply other threads:[~2013-04-22 12:38 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-04-22 8:33 [PATCH 1/2] dma: of: Remove restriction that #dma-cells can't be 0 Lars-Peter Clausen
2013-04-22 8:33 ` [PATCH 2/2] dma: of: Remove check on always true condition Lars-Peter Clausen
2013-04-22 12:38 ` Arnd Bergmann [this message]
2013-04-22 20:52 ` Jon Hunter
2013-04-22 21:00 ` Lars-Peter Clausen
2013-04-22 22:13 ` Jon Hunter
2013-04-22 12:38 ` [PATCH 1/2] dma: of: Remove restriction that #dma-cells can't be 0 Arnd Bergmann
2013-04-22 12:47 ` Lars-Peter Clausen
2013-04-22 14:54 ` Arnd Bergmann
2013-05-23 10:30 ` Vinod Koul
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=201304221438.29857.arnd@arndb.de \
--to=arnd@arndb.de \
--cc=jon-hunter@ti.com \
--cc=lars@metafoo.de \
--cc=linux-kernel@vger.kernel.org \
--cc=vinod.koul@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox