public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
From: Don Zickus <dzickus@redhat.com>
To: "Pan, Zhenjie" <zhenjie.pan@intel.com>
Cc: Stephane Eranian <eranian@google.com>,
	Peter Zijlstra <a.p.zijlstra@chello.nl>,
	"paulus@samba.org" <paulus@samba.org>,
	"mingo@redhat.com" <mingo@redhat.com>,
	"acme@ghostprotocols.net" <acme@ghostprotocols.net>,
	"akpm@linux-foundation.org" <akpm@linux-foundation.org>,
	"tglx@linutronix.de" <tglx@linutronix.de>,
	"Liu, Chuansheng" <chuansheng.liu@intel.com>,
	"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH v2] NMI: fix NMI period is not correct when cpu frequency changes issue.
Date: Mon, 22 Apr 2013 14:59:29 -0400	[thread overview]
Message-ID: <20130422185929.GZ79013@redhat.com> (raw)
In-Reply-To: <F98D4B5C3D86834DB612ABF854C98B7FB5FACF@SHSMSX101.ccr.corp.intel.com>

On Mon, Apr 22, 2013 at 12:50:34AM +0000, Pan, Zhenjie wrote:
> > I believe it mattered to the Chrome folks. They want the watchdog to be as
> > tight as possible so the user experience isn't a hang but a quick reboot
> > instead.  They like setting the watchdog to something like 2 seconds.
> > 
> > There was a patch a few months ago that tried to hack around this issue and I
> > suggested this approach as a better solution.  I forgot what the original
> > problem was.  Perhaps someone can jump in and explain the problem being
> > solved (other than the watchdog isn't always 10 seconds)?
> > 
> > Cheers,
> > Don
> 
> Yes, I also think the period is important sometimes.
> As I mentioned before, the case I meet is:
> When the system hang with interrupt disabled, we use NMI to detect.
> Then it will find hard lockup and cause a panic.
> Panic is very important for debug these kind of issues.
> 
> But if cpu frequency change, the period will be 2 times, 3 times even more.(if cpu can down from 2.0GHz to 200MHz, will be 10 times, it's a very big deviation)
> This make watchdog reset happen before hard lockup detect.

So you are saying with the longer hard lockup delay, the iTCO_wdt is
firing before the hard lockup detector?

Cheers,
Don

  reply	other threads:[~2013-04-22 18:59 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-04-16  6:57 [PATCH v2] NMI: fix NMI period is not correct when cpu frequency changes issue Pan, Zhenjie
2013-04-18 11:42 ` Peter Zijlstra
2013-04-18 12:04   ` Stephane Eranian
2013-04-18 13:39     ` Don Zickus
2013-04-22  0:50       ` Pan, Zhenjie
2013-04-22 18:59         ` Don Zickus [this message]
2013-04-23  0:52           ` Pan, Zhenjie
2013-04-22 20:37         ` Peter Zijlstra
2013-04-23 18:14           ` Don Zickus

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20130422185929.GZ79013@redhat.com \
    --to=dzickus@redhat.com \
    --cc=a.p.zijlstra@chello.nl \
    --cc=acme@ghostprotocols.net \
    --cc=akpm@linux-foundation.org \
    --cc=chuansheng.liu@intel.com \
    --cc=eranian@google.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mingo@redhat.com \
    --cc=paulus@samba.org \
    --cc=tglx@linutronix.de \
    --cc=zhenjie.pan@intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox