From: Vinod Koul <vinod.koul@intel.com>
To: Nicolas Ferre <nicolas.ferre@atmel.com>
Cc: ludovic.desroches@atmel.com,
linux-arm-kernel@lists.infradead.org, linux-mmc@vger.kernel.org,
linux-i2c@vger.kernel.org, plagnioj@jcrosoft.com,
Linux Kernel list <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH v3 1/6] at_hdmac: move to generic DMA binding
Date: Tue, 23 Apr 2013 09:14:07 +0530 [thread overview]
Message-ID: <20130423034407.GY24632@intel.com> (raw)
In-Reply-To: <51750F68.4040701@atmel.com>
On Mon, Apr 22, 2013 at 12:22:32PM +0200, Nicolas Ferre wrote:
> On 04/19/2013 11:11 AM, ludovic.desroches@atmel.com :
> > From: Ludovic Desroches <ludovic.desroches@atmel.com>
> > +#ifdef CONFIG_OF
> > +static bool at_dma_filter(struct dma_chan *chan, void *slave)
this is not defined for else case here. Also this could be CONFIG_DMA_OF...?
> > +{
> > + struct at_dma_slave *atslave = slave;
> > +
> > + if (atslave->dma_dev == chan->device->dev) {
> > + chan->private = atslave;
> > + return true;
> > + } else {
> > + return false;
> > + }
> > +}
--
~Vinod
next prev parent reply other threads:[~2013-04-23 4:15 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <1366362683-14496-1-git-send-email-ludovic.desroches@atmel.com>
[not found] ` <1366362683-14496-2-git-send-email-ludovic.desroches@atmel.com>
2013-04-22 10:22 ` [PATCH v3 1/6] at_hdmac: move to generic DMA binding Nicolas Ferre
2013-04-23 3:44 ` Vinod Koul [this message]
2013-04-29 13:28 ` Nicolas Ferre
2013-04-30 8:48 ` Vinod Koul
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20130423034407.GY24632@intel.com \
--to=vinod.koul@intel.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-i2c@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mmc@vger.kernel.org \
--cc=ludovic.desroches@atmel.com \
--cc=nicolas.ferre@atmel.com \
--cc=plagnioj@jcrosoft.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox