From: Tony Lindgren <tony@atomide.com>
To: Grygorii Strashko <grygorii.strashko@ti.com>
Cc: Samuel Ortiz <sameo@linux.intel.com>,
Wolfram Sang <wsa@the-dreams.de>,
"Ben Dooks (embedded platforms)" <ben-linux@fluff.org>,
Santosh Shilimkar <santosh.shilimkar@ti.com>,
linux-omap@vger.kernel.org, linux-i2c@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH 0/2] OMAP: fix boot sequence
Date: Tue, 23 Apr 2013 10:34:42 -0700 [thread overview]
Message-ID: <20130423173442.GF10155@atomide.com> (raw)
In-Reply-To: <1366723151-23209-1-git-send-email-grygorii.strashko@ti.com>
* Grygorii Strashko <grygorii.strashko@ti.com> [130423 06:25]:
> Hi
>
> There are two public discussions now related to OMAP boot and drivers
> initialization issues:
> "Multiple issues with omap4 panda es in linux next"
> http://www.spinics.net/lists/linux-omap/msg90241.html
> "[BUG] omap: mfd/regulator: twl/core: init order"
> http://www.spinics.net/lists/linux-omap/msg89980.html
>
> In both cases there are pinctrl-single/I2C/MFD/Regulators initailization issue:
> - regulators are not initialized because of twl,
> - twl is not initialized because of I2C,
> - I2C is not initialized because of pinctrl-single,
> - pinctrl-single is initialized at mudule/device init time.
> So, most everything will be shifted at late_initcall time.
>
> This may cause boot delay (more over, it can broken initialization of drivers
> which are not ready to use deferred probe mechanism yet, for example DSS).
>
> Introduced pathes shift I2C and TWL iniialization to module/device init layer
> instead of subsys init layer where initialization dependencies resolved
> indirectly in drivers/Makefile now.
>
> Grygorii Strashko (2):
> i2c: omap: convert to module_platform_driver()
> mfd: twl-core: convert to module_i2c_driver()
>
> drivers/i2c/busses/i2c-omap.c | 14 +-------------
> drivers/mfd/twl-core.c | 12 +-----------
> 2 files changed, 2 insertions(+), 24 deletions(-)
Thanks, I have few questions:
1. It seems that the real fix to the issues we're seeing
is to make the broken drivers to support -EPROBE_DEFER?
2. If so, can these be merged later on as clean-up?
3. Can these two patches be merged separately without
breaking things?
Regards,
Tony
next prev parent reply other threads:[~2013-04-23 17:34 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-04-23 13:19 [PATCH 0/2] OMAP: fix boot sequence Grygorii Strashko
2013-04-23 13:19 ` [PATCH 1/2] i2c: omap: convert to module_platform_driver() Grygorii Strashko
2013-06-03 20:59 ` Kevin Hilman
2013-06-04 11:32 ` Grygorii Strashko
2013-06-04 18:29 ` Kevin Hilman
2013-06-05 11:28 ` Grygorii Strashko
2013-06-05 13:50 ` Wolfram Sang
2013-06-06 14:58 ` Grygorii Strashko
2013-04-23 13:19 ` [PATCH 2/2] mfd: twl-core: convert to module_i2c_driver() Grygorii Strashko
2013-05-16 22:17 ` Samuel Ortiz
2013-05-16 22:58 ` Tony Lindgren
2013-05-17 10:46 ` Grygorii Strashko
2013-04-23 17:34 ` Tony Lindgren [this message]
2013-04-23 17:50 ` [PATCH 0/2] OMAP: fix boot sequence Grygorii Strashko
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20130423173442.GF10155@atomide.com \
--to=tony@atomide.com \
--cc=ben-linux@fluff.org \
--cc=grygorii.strashko@ti.com \
--cc=linux-i2c@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-omap@vger.kernel.org \
--cc=sameo@linux.intel.com \
--cc=santosh.shilimkar@ti.com \
--cc=wsa@the-dreams.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox