From: Thierry Reding <thierry.reding@avionic-design.de>
To: Chao Xie <chao.xie@marvell.com>
Cc: linux-kernel@vger.kernel.org, xiechao.mail@gmail.com
Subject: Re: [PATCH V3 2/3] pwm: pxa: use module_platform_driver for driver register
Date: Wed, 24 Apr 2013 09:14:15 +0200 [thread overview]
Message-ID: <20130424071415.GE1429@avionic-0098.mockup.avionic-design.de> (raw)
In-Reply-To: <1366770234-5829-3-git-send-email-chao.xie@marvell.com>
[-- Attachment #1: Type: text/plain, Size: 383 bytes --]
On Tue, Apr 23, 2013 at 10:23:53PM -0400, Chao Xie wrote:
> Signed-off-by: Chao Xie <chao.xie@marvell.com>
The subject is a bit redundant. Something like:
pwm: pxa: use module_platform_driver()
would be enough.
But I'd like to see a commit message which also mentions that the driver
used to be registered with arch_initcall() and why it is okay that it
isn't anymore.
Thierry
[-- Attachment #2: Type: application/pgp-signature, Size: 836 bytes --]
next prev parent reply other threads:[~2013-04-24 7:14 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-04-24 2:23 [PATCH V3 0/3] pwm: pxa: bug fix and device tree support Chao Xie
2013-04-24 2:23 ` [PATCH V3 1/3] pwm: pxa: ARCH_MMP share same pwm driver with ARCH_PXA Chao Xie
2013-04-24 7:15 ` Thierry Reding
2013-04-24 2:23 ` [PATCH V3 2/3] pwm: pxa: use module_platform_driver for driver register Chao Xie
2013-04-24 7:14 ` Thierry Reding [this message]
2013-04-24 2:23 ` [PATCH V3 3/3] pwm: pxa: add device tree support Chao Xie
2013-04-24 7:11 ` Thierry Reding
2013-04-24 7:33 ` Thierry Reding
2013-04-24 7:36 ` [PATCH V3 0/3] pwm: pxa: bug fix and " Thierry Reding
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20130424071415.GE1429@avionic-0098.mockup.avionic-design.de \
--to=thierry.reding@avionic-design.de \
--cc=chao.xie@marvell.com \
--cc=linux-kernel@vger.kernel.org \
--cc=xiechao.mail@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox