public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
From: Ingo Molnar <mingo@kernel.org>
To: Frederic Weisbecker <fweisbec@gmail.com>
Cc: LKML <linux-kernel@vger.kernel.org>,
	Chris Metcalf <cmetcalf@tilera.com>,
	Christoph Lameter <cl@linux.com>,
	Geoff Levand <geoff@infradead.org>,
	Gilad Ben Yossef <gilad@benyossef.com>,
	Hakan Akkan <hakanakkan@gmail.com>,
	Kevin Hilman <khilman@linaro.org>,
	Li Zhong <zhong@linux.vnet.ibm.com>,
	Oleg Nesterov <oleg@redhat.com>,
	"Paul E. McKenney" <paulmck@linux.vnet.ibm.com>,
	Paul Gortmaker <paul.gortmaker@windriver.com>,
	Peter Zijlstra <peterz@infradead.org>,
	Steven Rostedt <rostedt@goodmis.org>,
	Thomas Gleixner <tglx@linutronix.de>,
	Stephane Eranian <eranian@google.com>,
	Jiri Olsa <jolsa@redhat.com>
Subject: Re: [GIT PULL] nohz: Adaptively stop the tick, finally
Date: Wed, 24 Apr 2013 09:32:59 +0200	[thread overview]
Message-ID: <20130424073259.GC1780@gmail.com> (raw)
In-Reply-To: <1366657186-20556-1-git-send-email-fweisbec@gmail.com>


* Frederic Weisbecker <fweisbec@gmail.com> wrote:

> Ingo,
> 
> Please pull the latest full dynticks branch that can found at:
> 
> git://git.kernel.org/pub/scm/linux/kernel/git/frederic/linux-dynticks.git
> 	timers/nohz
> 
> HEAD: 67826eae8c16dbf00c262be6ec15021bb42f69c4
> 
> This handles perf and CPUs that get more than one task and fix posix cpu timers
> handling.
> 
> This can finally stop the tick. It boots and doesn't crash, as far as I tested.
> 
> Now what's left:
> 
> * Kick CPUs' tick when the clock is marked unstable
> 
> * Kick CPUs when they extend the RCU grace periods too much by staying in
> the kernel for too long (we are discussing this with Paul).
> 
> * sched_class:task_tick(). There are gazillions statistics maintained there.
> It's probably mostly about local and global fairness. May be for other stuff
> too (cgroups, etc...).
> 
> * update_cpu_load_active(): again, various stats maintained there
> 
> * load balancing (see trigger_load_balance() usually called from the tick).
> 
> I hope we can handle these things progressively in the long run.
> 
> Thanks.
> 
> ---
> Frederic Weisbecker (10):
>   posix_timers: Fix pre-condition to stop the tick on full dynticks
>   perf: Kick full dynticks CPU if events rotation is needed
>   perf: New helper to prevent full dynticks CPUs from stopping tick
>   sched: Kick full dynticks CPU that have more than one task enqueued.
>   sched: New helper to prevent from stopping the tick in full dynticks
>   nohz: Re-evaluate the tick from the scheduler IPI
>   nohz: Implement full dynticks kick
>   nohz: Prepare to stop the tick on irq exit
>   nohz: Re-evaluate the tick for the new task after a context switch
>   nohz: Disable the tick when irq resume in full dynticks CPU
> 
>  include/linux/perf_event.h |    6 +++
>  include/linux/sched.h      |    6 +++
>  include/linux/tick.h       |    4 ++
>  kernel/events/core.c       |   17 +++++++-
>  kernel/posix-cpu-timers.c  |    6 +-
>  kernel/sched/core.c        |   24 +++++++++++-
>  kernel/sched/sched.h       |   11 +++++
>  kernel/softirq.c           |   19 ++++++--
>  kernel/time/tick-sched.c   |   95 ++++++++++++++++++++++++++++++++++++++-----
>  9 files changed, 167 insertions(+), 21 deletions(-)

Pulled, thanks Frederic!

One detail: 'make oldconfig' gave me:

 Timer tick handling
   1. Periodic timer ticks (constant rate, no dynticks) (HZ_PERIODIC) (NEW)
 > 2. Idle dynticks system (tickless idle) (NO_HZ_IDLE) (NEW)

I.e. CONFIG_NO_HZ_IDLE is picked by default. The default should really be 
CONFIG_HZ_PERIODIC - so that people can easily enable full dynticks but 
are not defaulted into it unknowingly.

Thanks,

	Ingo

  parent reply	other threads:[~2013-04-24  7:33 UTC|newest]

Thread overview: 15+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-04-22 18:59 [GIT PULL] nohz: Adaptively stop the tick, finally Frederic Weisbecker
2013-04-22 18:59 ` [PATCH 01/10] posix_timers: Fix pre-condition to stop the tick on full dynticks Frederic Weisbecker
2013-04-22 18:59 ` [PATCH 02/10] perf: Kick full dynticks CPU if events rotation is needed Frederic Weisbecker
2013-04-22 18:59 ` [PATCH 03/10] perf: New helper to prevent full dynticks CPUs from stopping tick Frederic Weisbecker
2013-04-22 18:59 ` [PATCH 04/10] sched: Kick full dynticks CPU that have more than one task enqueued Frederic Weisbecker
2013-04-22 18:59 ` [PATCH 05/10] sched: New helper to prevent from stopping the tick in full dynticks Frederic Weisbecker
2013-04-22 18:59 ` [PATCH 06/10] nohz: Re-evaluate the tick from the scheduler IPI Frederic Weisbecker
2013-04-22 18:59 ` [PATCH 07/10] nohz: Implement full dynticks kick Frederic Weisbecker
2013-04-22 18:59 ` [PATCH 08/10] nohz: Prepare to stop the tick on irq exit Frederic Weisbecker
2013-04-22 18:59 ` [PATCH 09/10] nohz: Re-evaluate the tick for the new task after a context switch Frederic Weisbecker
2013-04-22 18:59 ` [PATCH 10/10] nohz: Disable the tick when irq resume in full dynticks CPU Frederic Weisbecker
2013-04-24  7:32 ` Ingo Molnar [this message]
2013-04-24  7:38   ` [GIT PULL] nohz: Adaptively stop the tick, finally Ingo Molnar
2013-04-24 14:50     ` Frederic Weisbecker
2013-04-25  6:28       ` Ingo Molnar

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20130424073259.GC1780@gmail.com \
    --to=mingo@kernel.org \
    --cc=cl@linux.com \
    --cc=cmetcalf@tilera.com \
    --cc=eranian@google.com \
    --cc=fweisbec@gmail.com \
    --cc=geoff@infradead.org \
    --cc=gilad@benyossef.com \
    --cc=hakanakkan@gmail.com \
    --cc=jolsa@redhat.com \
    --cc=khilman@linaro.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=oleg@redhat.com \
    --cc=paul.gortmaker@windriver.com \
    --cc=paulmck@linux.vnet.ibm.com \
    --cc=peterz@infradead.org \
    --cc=rostedt@goodmis.org \
    --cc=tglx@linutronix.de \
    --cc=zhong@linux.vnet.ibm.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox