From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1758226Ab3DXIzQ (ORCPT ); Wed, 24 Apr 2013 04:55:16 -0400 Received: from mail-we0-f169.google.com ([74.125.82.169]:39641 "EHLO mail-we0-f169.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1757617Ab3DXIzO (ORCPT ); Wed, 24 Apr 2013 04:55:14 -0400 Date: Wed, 24 Apr 2013 09:55:07 +0100 From: Lee Jones To: Vinod Koul Cc: linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, arnd@arndb.de, linus.walleij@stericsson.com, Dan Williams , Per Forlin , Rabin Vincent Subject: Re: [PATCH 17/32] dmaengine: ste_dma40: Remove redundant argument from d40_phy_cfg() Message-ID: <20130424085507.GK17416@gmail.com> References: <1366279934-30761-1-git-send-email-lee.jones@linaro.org> <1366279934-30761-18-git-send-email-lee.jones@linaro.org> <20130422093423.GD24632@intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <20130422093423.GD24632@intel.com> User-Agent: Mutt/1.5.21 (2010-09-15) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org > > + if ((cfg->dir == STEDMA40_PERIPH_TO_MEM) || > > + (cfg->dir == STEDMA40_PERIPH_TO_PERIPH)) { > Why would you need your own direction defines, I see that there is not much > diff between these and what dmaengine defines, so perhpas you could use > those? Same with these ones, subsequent patch? -- Lee Jones Linaro ST-Ericsson Landing Team Lead Linaro.org │ Open source software for ARM SoCs Follow Linaro: Facebook | Twitter | Blog