From: Frederic Weisbecker <fweisbec@gmail.com>
To: Jiri Olsa <jolsa@redhat.com>
Cc: linux-kernel@vger.kernel.org,
Thomas Gleixner <tglx@linutronix.de>,
"H. Peter Anvin" <hpa@zytor.com>,
Andi Kleen <andi@firstfloor.org>, Oleg Nesterov <oleg@redhat.com>,
Arnaldo Carvalho de Melo <acme@ghostprotocols.net>,
Peter Zijlstra <a.p.zijlstra@chello.nl>,
Ingo Molnar <mingo@elte.hu>, Paul Mackerras <paulus@samba.org>,
Corey Ashford <cjashfor@linux.vnet.ibm.com>,
Vince Weaver <vincent.weaver@maine.edu>,
Stephane Eranian <eranian@google.com>
Subject: Re: [PATCH 1/6] signal x86: Propage RF EFLAGS bit throught the signal restore call
Date: Wed, 24 Apr 2013 17:24:37 +0200 [thread overview]
Message-ID: <20130424152412.GB6993@somewhere> (raw)
In-Reply-To: <1362940871-24486-2-git-send-email-jolsa@redhat.com>
On Sun, Mar 10, 2013 at 07:41:06PM +0100, Jiri Olsa wrote:
> Adding RF EFLAGS bit to be restored on return from signal from
> the original register context before the signal was entered.
>
> This will prevent the RF flag to disappear when returning
> from exception due to the signal handler being executed.
>
> Signed-off-by: Jiri Olsa <jolsa@redhat.com>
> Cc: Thomas Gleixner <tglx@linutronix.de>
> Cc: H. Peter Anvin <hpa@zytor.com>
> Cc: Andi Kleen <andi@firstfloor.org>
> Cc: Oleg Nesterov <oleg@redhat.com>
> Cc: Arnaldo Carvalho de Melo <acme@ghostprotocols.net>
> Cc: Peter Zijlstra <a.p.zijlstra@chello.nl>
> Cc: Ingo Molnar <mingo@elte.hu>
> Cc: Paul Mackerras <paulus@samba.org>
> Cc: Corey Ashford <cjashfor@linux.vnet.ibm.com>
> Cc: Frederic Weisbecker <fweisbec@gmail.com>
> Cc: Vince Weaver <vincent.weaver@maine.edu>
> Cc: Stephane Eranian <eranian@google.com>
> ---
> arch/x86/ia32/ia32_signal.c | 2 --
> arch/x86/include/asm/sighandling.h | 4 ++--
> arch/x86/kernel/signal.c | 6 ------
> 3 files changed, 2 insertions(+), 10 deletions(-)
>
> diff --git a/arch/x86/ia32/ia32_signal.c b/arch/x86/ia32/ia32_signal.c
> index cf1a471..bccfca6 100644
> --- a/arch/x86/ia32/ia32_signal.c
> +++ b/arch/x86/ia32/ia32_signal.c
> @@ -34,8 +34,6 @@
> #include <asm/sys_ia32.h>
> #include <asm/smap.h>
>
> -#define FIX_EFLAGS __FIX_EFLAGS
> -
> int copy_siginfo_to_user32(compat_siginfo_t __user *to, siginfo_t *from)
> {
> int err = 0;
> diff --git a/arch/x86/include/asm/sighandling.h b/arch/x86/include/asm/sighandling.h
> index beff97f..7a95816 100644
> --- a/arch/x86/include/asm/sighandling.h
> +++ b/arch/x86/include/asm/sighandling.h
> @@ -7,10 +7,10 @@
>
> #include <asm/processor-flags.h>
>
> -#define __FIX_EFLAGS (X86_EFLAGS_AC | X86_EFLAGS_OF | \
> +#define FIX_EFLAGS (X86_EFLAGS_AC | X86_EFLAGS_OF | \
> X86_EFLAGS_DF | X86_EFLAGS_TF | X86_EFLAGS_SF | \
> X86_EFLAGS_ZF | X86_EFLAGS_AF | X86_EFLAGS_PF | \
> - X86_EFLAGS_CF)
> + X86_EFLAGS_CF | X86_EFLAGS_RF)
>
> void signal_fault(struct pt_regs *regs, void __user *frame, char *where);
>
> diff --git a/arch/x86/kernel/signal.c b/arch/x86/kernel/signal.c
> index 6956299..9df4c0b 100644
> --- a/arch/x86/kernel/signal.c
> +++ b/arch/x86/kernel/signal.c
> @@ -43,12 +43,6 @@
>
> #include <asm/sigframe.h>
>
> -#ifdef CONFIG_X86_32
> -# define FIX_EFLAGS (__FIX_EFLAGS | X86_EFLAGS_RF)
Does anybody know why we had RF not restored in x86-32?
next prev parent reply other threads:[~2013-04-24 15:24 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-03-10 18:41 [PATCHv2 0/6] perf, signal x86: Fix breakpoint events overflow handling Jiri Olsa
2013-03-10 18:41 ` [PATCH 1/6] signal x86: Propage RF EFLAGS bit throught the signal restore call Jiri Olsa
2013-04-16 1:05 ` Frederic Weisbecker
2013-04-16 14:42 ` Oleg Nesterov
2013-04-17 20:02 ` Oleg Nesterov
2013-04-24 15:39 ` Frederic Weisbecker
2013-04-24 15:24 ` Frederic Weisbecker [this message]
2013-03-10 18:41 ` [PATCH 2/6] signal x86: Clear RF EFLAGS bit for signal handler Jiri Olsa
2013-03-10 18:41 ` [PATCH 3/6] signal x86: Merge EFLAGS bit clearing into single statement Jiri Olsa
2013-03-10 18:41 ` [PATCH 4/6] perf: Fix hw breakpoints overflow period sampling Jiri Olsa
2013-04-04 16:10 ` Peter Zijlstra
2013-03-10 18:41 ` [PATCH 5/6] perf tests: Test breakpoint overflow signal handler Jiri Olsa
2013-03-21 11:38 ` [tip:perf/core] " tip-bot for Jiri Olsa
2013-03-10 18:41 ` [PATCH 6/6] perf tests: Test breakpoint overflow signal handler counts Jiri Olsa
2013-03-21 11:39 ` [tip:perf/core] " tip-bot for Jiri Olsa
2013-03-24 15:15 ` [PATCHv2 0/6] perf, signal x86: Fix breakpoint events overflow handling Jiri Olsa
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20130424152412.GB6993@somewhere \
--to=fweisbec@gmail.com \
--cc=a.p.zijlstra@chello.nl \
--cc=acme@ghostprotocols.net \
--cc=andi@firstfloor.org \
--cc=cjashfor@linux.vnet.ibm.com \
--cc=eranian@google.com \
--cc=hpa@zytor.com \
--cc=jolsa@redhat.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@elte.hu \
--cc=oleg@redhat.com \
--cc=paulus@samba.org \
--cc=tglx@linutronix.de \
--cc=vincent.weaver@maine.edu \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox