public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
From: Robin Holt <holt@sgi.com>
To: Ingo Molnar <mingo@kernel.org>
Cc: Andrew Morton <akpm@linux-foundation.org>,
	Robin Holt <holt@sgi.com>, "H. Peter Anvin" <hpa@zytor.com>,
	"Srivatsa S. Bhat" <srivatsa.bhat@linux.vnet.ibm.com>,
	Russ Anderson <rja@sgi.com>,
	Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
	the arch/x86 maintainers <x86@kernel.org>,
	Tejun Heo <tj@kernel.org>
Subject: Re: [PATCH -v6 2/5] Migrate shutdown/reboot to boot cpu.
Date: Thu, 25 Apr 2013 10:36:46 -0500	[thread overview]
Message-ID: <20130425153646.GX3658@sgi.com> (raw)
In-Reply-To: <20130425073437.GA12868@gmail.com>

On Thu, Apr 25, 2013 at 09:34:37AM +0200, Ingo Molnar wrote:
> 
> * Andrew Morton <akpm@linux-foundation.org> wrote:
> 
> > On Thu, 25 Apr 2013 08:57:04 +0200 Ingo Molnar <mingo@kernel.org> wrote:
> > 
> > > > PF_THREAD_BOUND was removed/replaced in linux-next's a9ab775bc
> > > > ("workqueue: directly restore CPU affinity of workers from CPU_ONLINE")
> > > 
> > > I don't see PF_THREAD_BOUND being removed by commit a9ab775bc. Did you 
> > > mean some other commit?
> > 
> > commit 14a40ffccd6163bbcd1d6f32b28a88ffe6149fc6
> > Author: Tejun Heo <tj@kernel.org>
> > Date:   Tue Mar 19 13:45:20 2013 -0700
> > 
> >     sched: replace PF_THREAD_BOUND with PF_NO_SETAFFINITY
> 
> I don't think much action is needed: whenever someone integrates the 
> workqueue tree with these reboot changes, or the workqueue changes hit 
> upstream, a s/PF_THREAD_BOUND/PF_NO_SETAFFINITY should do the trick, 
> right?
> 
> Btw., if that's true then the workqueue tree should probably grow this 
> helper:
> 
> 	#define PF_THREAD_BOUND PF_NO_SETAFFINITY

Andrew, how about I add:
--- a/kernel/reboot.c
+++ b/kernel/reboot.c
@@ -155,6 +155,9 @@ static int __init reboot_setup(char *str)
 }
 __setup("reboot=", reboot_setup);
 
+#ifndef PF_THREAD_BOUND
+#define PF_THREAD_BOUND PF_NO_SETAFFINITY
+#endif
 
 static void migrate_to_reboot_cpu(void)
 {

to this patch and then add another patch to the series to remove those.
That will make the stable pull more clear and accomplish the same final
outcome.

Thanks,
Robin

  reply	other threads:[~2013-04-25 15:36 UTC|newest]

Thread overview: 14+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-04-24 11:18 [PATCH -v6 0/5] Shutdown from reboot_cpuid without stopping other cpus Robin Holt
2013-04-24 11:18 ` [PATCH -v6 1/5] CPU hotplug: Provide a generic helper to disable/enable CPU hotplug Robin Holt
2013-04-24 11:18 ` [PATCH -v6 2/5] Migrate shutdown/reboot to boot cpu Robin Holt
2013-04-24 22:17   ` Andrew Morton
2013-04-24 22:19     ` Andrew Morton
2013-04-25  6:57     ` Ingo Molnar
2013-04-25  7:29       ` Andrew Morton
2013-04-25  7:34         ` Ingo Molnar
2013-04-25 15:36           ` Robin Holt [this message]
2013-04-24 11:18 ` [PATCH -v6 3/5] Move shutdown/reboot related functions to kernel/reboot.c Robin Holt
2013-04-24 11:18 ` [PATCH -v6 4/5] checkpatch.pl the new kernel/reboot.c file Robin Holt
2013-04-24 11:18 ` [PATCH -v6 5/5] Move arch/x86 reboot= handling to generic kernel Robin Holt
2013-04-24 22:11   ` Andrew Morton
2013-04-25 21:23 ` [PATCH -v6 0/5] Shutdown from reboot_cpuid without stopping other cpus Robin Holt

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20130425153646.GX3658@sgi.com \
    --to=holt@sgi.com \
    --cc=akpm@linux-foundation.org \
    --cc=hpa@zytor.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mingo@kernel.org \
    --cc=rja@sgi.com \
    --cc=srivatsa.bhat@linux.vnet.ibm.com \
    --cc=tj@kernel.org \
    --cc=x86@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox