From: "H. Peter Anvin" <hpa@linux.intel.com>
To: Linus Torvalds <torvalds@linux-foundation.org>
Cc: Borislav Petkov <bp@suse.de>,
"H. Peter Anvin" <hpa@linux.intel.com>,
"H. Peter Anvin" <hpa@zytor.com>, Ingo Molnar <mingo@elte.hu>,
Josh Boyer <jwboyer@redhat.com>,
Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
Matt Fleming <matt.fleming@intel.com>,
Matthew Garrett <matthew.garrett@nebula.com>,
Paul Bolle <pebolle@tiscali.nl>,
Thomas Gleixner <tglx@linutronix.de>
Subject: [GIT PULL] x86 fixes for 3.9
Date: Thu, 25 Apr 2013 14:44:43 -0700 [thread overview]
Message-ID: <201304252144.r3PLihDe025383@terminus.zytor.com> (raw)
Hi Linus,
The following changes since commit 0fbd06761f5c17cc9b20e02af60fd7ee9c895996:
Merge git://git.kernel.org/pub/scm/linux/kernel/git/davem/sparc (2013-04-24 17:10:18 -0700)
are available in the git repository at:
git://git.kernel.org/pub/scm/linux/kernel/git/tip/tip.git x86-urgent-for-linus
This is exclusively two EFI fixes:
* The EFI variable anti-bricking algorithm merged in -rc8 broke
booting on some Apple machines because they implement EFI spec
1.10, which doesn't provide a QueryVariableInfo() runtime function
and the logic used to check for the existence of that function was
insufficient. Fix from Josh Boyer.
* The anti-bricking algorithm also introduced a compiler warning on
32-bit. Fix from Borislav Petkov.
----------------------------------------------------------------
Borislav Petkov (1):
x86, efi: Fix a build warning
H. Peter Anvin (1):
Merge tag 'efi-urgent' into x86/urgent
Josh Boyer (1):
efi: Check EFI revision in setup_efi_vars
arch/x86/boot/compressed/eboot.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/arch/x86/boot/compressed/eboot.c b/arch/x86/boot/compressed/eboot.c
index 8615f75..35ee62f 100644
--- a/arch/x86/boot/compressed/eboot.c
+++ b/arch/x86/boot/compressed/eboot.c
@@ -258,7 +258,7 @@ static efi_status_t setup_efi_vars(struct boot_params *params)
u64 store_size, remaining_size, var_size;
efi_status_t status;
- if (!sys_table->runtime->query_variable_info)
+ if (sys_table->runtime->hdr.revision < EFI_2_00_SYSTEM_TABLE_REVISION)
return EFI_UNSUPPORTED;
data = (struct setup_data *)(unsigned long)params->hdr.setup_data;
@@ -266,7 +266,7 @@ static efi_status_t setup_efi_vars(struct boot_params *params)
while (data && data->next)
data = (struct setup_data *)(unsigned long)data->next;
- status = efi_call_phys4(sys_table->runtime->query_variable_info,
+ status = efi_call_phys4((void *)sys_table->runtime->query_variable_info,
EFI_VARIABLE_NON_VOLATILE |
EFI_VARIABLE_BOOTSERVICE_ACCESS |
EFI_VARIABLE_RUNTIME_ACCESS, &store_size,
next reply other threads:[~2013-04-25 21:45 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-04-25 21:44 H. Peter Anvin [this message]
2013-04-25 22:20 ` [GIT PULL] x86 fixes for 3.9 Linus Torvalds
2013-04-25 22:23 ` Matthew Garrett
2013-04-25 22:53 ` Michel Lespinasse
2013-04-25 22:54 ` H. Peter Anvin
2013-04-25 23:11 ` Michel Lespinasse
2013-04-26 7:12 ` Matt Fleming
2013-04-26 7:43 ` Michel Lespinasse
2013-04-26 8:49 ` Matt Fleming
2013-04-26 9:02 ` Michel Lespinasse
2013-04-26 9:44 ` Matt Fleming
2013-04-26 7:29 ` Ingo Molnar
2013-04-26 9:01 ` Matt Fleming
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=201304252144.r3PLihDe025383@terminus.zytor.com \
--to=hpa@linux.intel.com \
--cc=bp@suse.de \
--cc=hpa@zytor.com \
--cc=jwboyer@redhat.com \
--cc=linux-kernel@vger.kernel.org \
--cc=matt.fleming@intel.com \
--cc=matthew.garrett@nebula.com \
--cc=mingo@elte.hu \
--cc=pebolle@tiscali.nl \
--cc=tglx@linutronix.de \
--cc=torvalds@linux-foundation.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox