Re: [PATCH] x86: Add a Kconfig shortcut for a kvm-bootable kernel

Borislav Petkov
2013-04-18T10:18:32Z

On Thu, Apr 18, 2013 at 11:55:33AM +0200, Geert Uytterhoeven wrote:
> On Thu, Apr 18, 2013 at 11:46 AM, Borislav Petkov <bp@alien8.de> wrote:
> > ok, maybe I wasn't clear enough. My proposal was to actually add all (or
> > maybe not *all* of them, but most) those selects above to the KVM_GUEST
> > config option. Because, you very probably want to select all that stuff
> > above anyway if you want to build a kvm guest kernel, no?
> >
> > IOW, something which says "Enable KVM guest support" should enable all
> > the stuff needed for that.
>
> "needed" yes,
> "probably" no, as there's no way to disable them if they're selected
> unconditionally.
>
> Perhaps you can make the "probably" selects depend on !EXPERT to fix this?

Nah, I don't want to really involve EXPERT here. You could point,
though, which are the ones one probably won't select even though it
would be good to have them on and I could stick them in the second,
kernel testing option.

IOW, The way it currently shapes up is this:

* CONFIG_KVM_GUEST - maybe not change it at all, depending on what kvm
people want in the end.

* CONFIG_KVM_KERNEL_TESTING - all the things you would - probably or
really - need selected so that you don't go and hunt Kconfig options
just so the damn guest kernel boots. And not only that but also
convenience stuff like debugging options and such so that you have the
chance of getting some more info when the guest dies.

That second option is to be enabled when building the guest kernel only,
of course.

Better?

--
Regards/Gruss,
Boris.

Sent from a fat crate under my desk. Formatting is fine.
--