public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
From: Ingo Molnar <mingo@kernel.org>
To: Matthew Garrett <matthew.garrett@nebula.com>
Cc: Linus Torvalds <torvalds@linux-foundation.org>,
	"H. Peter Anvin" <hpa@linux.intel.com>,
	Borislav Petkov <bp@suse.de>, "H. Peter Anvin" <hpa@zytor.com>,
	Ingo Molnar <mingo@elte.hu>, Josh Boyer <jwboyer@redhat.com>,
	Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
	Matt Fleming <matt.fleming@intel.com>,
	Paul Bolle <pebolle@tiscali.nl>,
	Thomas Gleixner <tglx@linutronix.de>
Subject: Re: [GIT PULL] x86 fixes for 3.9
Date: Fri, 26 Apr 2013 09:29:19 +0200	[thread overview]
Message-ID: <20130426072919.GA31557@gmail.com> (raw)
In-Reply-To: <1366928604.9976.3.camel@x230>


* Matthew Garrett <matthew.garrett@nebula.com> wrote:

> On Thu, 2013-04-25 at 15:20 -0700, Linus Torvalds wrote:
> > On Thu, Apr 25, 2013 at 2:44 PM, H. Peter Anvin <hpa@linux.intel.com> wrote:
> > >
> > > -       if (!sys_table->runtime->query_variable_info)
> > > +       if (sys_table->runtime->hdr.revision < EFI_2_00_SYSTEM_TABLE_REVISION)
> > >                 return EFI_UNSUPPORTED;
> > 
> > Is a EFI 2.00 system table *guaranteed* to have that
> > "query_variable_info" function? The above adds the version check, but
> > removes the check for a NULL pointer.
> 
> As far as the spec's concerned, yes. As far as reality's concerned - if
> anything doesn't provide it, we're already crashing when
> efi_virt_query_variable_info() gets called. Nobody's complained so far.

I'm worried about the fragility of this code - this is firmware code ...

I think firmware code should be fundamentally paranoid and robust, and in 
this case treat all EFI-provided data as hostile and do a much sanity 
checking of it as possible - and provide an actionable error message if 
the checks fail, not just 'crash'.

Even if no-one complained, yet.

Thanks,

	Ingo

  parent reply	other threads:[~2013-04-26  7:29 UTC|newest]

Thread overview: 13+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-04-25 21:44 [GIT PULL] x86 fixes for 3.9 H. Peter Anvin
2013-04-25 22:20 ` Linus Torvalds
2013-04-25 22:23   ` Matthew Garrett
2013-04-25 22:53     ` Michel Lespinasse
2013-04-25 22:54       ` H. Peter Anvin
2013-04-25 23:11         ` Michel Lespinasse
2013-04-26  7:12           ` Matt Fleming
2013-04-26  7:43             ` Michel Lespinasse
2013-04-26  8:49               ` Matt Fleming
2013-04-26  9:02                 ` Michel Lespinasse
2013-04-26  9:44                   ` Matt Fleming
2013-04-26  7:29     ` Ingo Molnar [this message]
2013-04-26  9:01       ` Matt Fleming

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20130426072919.GA31557@gmail.com \
    --to=mingo@kernel.org \
    --cc=bp@suse.de \
    --cc=hpa@linux.intel.com \
    --cc=hpa@zytor.com \
    --cc=jwboyer@redhat.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=matt.fleming@intel.com \
    --cc=matthew.garrett@nebula.com \
    --cc=mingo@elte.hu \
    --cc=pebolle@tiscali.nl \
    --cc=tglx@linutronix.de \
    --cc=torvalds@linux-foundation.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox