public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
From: Frederic Weisbecker <fweisbec@gmail.com>
To: "Paul E. McKenney" <paulmck@linux.vnet.ibm.com>
Cc: Ingo Molnar <mingo@kernel.org>,
	LKML <linux-kernel@vger.kernel.org>,
	Christoph Lameter <cl@linux.com>,
	Hakan Akkan <hakanakkan@gmail.com>,
	Kevin Hilman <khilman@linaro.org>,
	Li Zhong <zhong@linux.vnet.ibm.com>,
	Paul Gortmaker <paul.gortmaker@windriver.com>,
	Peter Zijlstra <peterz@infradead.org>,
	Steven Rostedt <rostedt@goodmis.org>,
	Thomas Gleixner <tglx@linutronix.de>
Subject: Re: [PATCH 1/2] nohz: Select VIRT_CPU_ACCOUNTING_GEN from full dynticks config
Date: Fri, 26 Apr 2013 18:22:15 +0200	[thread overview]
Message-ID: <20130426162214.GB30716@somewhere> (raw)
In-Reply-To: <20130426153956.GB3860@linux.vnet.ibm.com>

On Fri, Apr 26, 2013 at 08:39:56AM -0700, Paul E. McKenney wrote:
> >  config VIRT_CPU_ACCOUNTING_GEN
> >  	bool "Full dynticks CPU time accounting"
> > -	depends on HAVE_CONTEXT_TRACKING && 64BIT
> > +	depends on HAVE_CONTEXT_TRACKING && 64BIT && NO_HZ_FULL
> 
> Do you really want this change?  This prohibits VIRT_CPU_ACCOUNTING_GEN
> unless NO_HZ_FULL, which means that it can no longer be used in situations
> where it used to be usable.  My guess is that you want to leave this
> particular line as it was.

Hmm, this can make sense. This can be used to perform comparisons between
tick-based and tickless cputime accounting easily.

I'll respin.

  reply	other threads:[~2013-04-26 16:22 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-04-26 14:53 [GIT PULL] nohz: A few improvements Frederic Weisbecker
2013-04-26 14:53 ` [PATCH 1/2] nohz: Select VIRT_CPU_ACCOUNTING_GEN from full dynticks config Frederic Weisbecker
2013-04-26 15:39   ` Paul E. McKenney
2013-04-26 16:22     ` Frederic Weisbecker [this message]
2013-04-26 23:01       ` Frederic Weisbecker
2013-04-27  7:19         ` Ingo Molnar
2013-05-13 21:16   ` Kevin Hilman
2013-04-26 14:53 ` [PATCH 2/2] cputime_nsecs: use math64.h for nsec resolution conversion helpers Frederic Weisbecker

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20130426162214.GB30716@somewhere \
    --to=fweisbec@gmail.com \
    --cc=cl@linux.com \
    --cc=hakanakkan@gmail.com \
    --cc=khilman@linaro.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mingo@kernel.org \
    --cc=paul.gortmaker@windriver.com \
    --cc=paulmck@linux.vnet.ibm.com \
    --cc=peterz@infradead.org \
    --cc=rostedt@goodmis.org \
    --cc=tglx@linutronix.de \
    --cc=zhong@linux.vnet.ibm.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox