From: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
To: Qiaowei Ren <qiaowei.ren@intel.com>
Cc: Arnd Bergmann <arnd@arndb.de>,
Richard L Maliszewski <richard.l.maliszewski@intel.com>,
Shane Wang <shane.wang@intel.com>, Gang Wei <gang.wei@intel.com>,
linux-kernel@vger.kernel.org,
Xiaoyan Zhang <xiaoyan.zhang@intel.com>
Subject: Re: [PATCH 3/5] driver: provide sysfs interfaces to access TXT log
Date: Sat, 27 Apr 2013 06:17:15 -0700 [thread overview]
Message-ID: <20130427131715.GB32432@kroah.com> (raw)
In-Reply-To: <1367074580-16530-4-git-send-email-qiaowei.ren@intel.com>
On Sat, Apr 27, 2013 at 10:56:18PM +0800, Qiaowei Ren wrote:
> +ssize_t sysfs_create_log(struct kobject *parent)
> +{
> + struct kobject *log_kobj;
> + int retval;
> +
> + log_kobj = kobject_create_and_add("log", parent);
> + if (!log_kobj)
> + return -ENOMEM;
> +
> + retval = sysfs_create_group(log_kobj, &log_attr_grp);
> + if (retval)
> + kobject_put(log_kobj);
> + return retval;
> +}
> +EXPORT_SYMBOL_GPL(sysfs_create_log);
Seriously? That's what you are calling this function?
{sigh}
Please, go get this patch series reviewed by other, experienced, Intel
developers, before you send it out again. There's loads of things wrong
with this series, and they can help you out much easier, and nicer, than
I'm going to be here.
Oh, and NEVER use "raw" kobjects, by doing that, you know you are doing
something wrong in a driver.
greg k-h
next prev parent reply other threads:[~2013-04-27 13:17 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-04-27 14:56 [PATCH 0/5] TXT driver Qiaowei Ren
2013-04-27 14:56 ` [PATCH 1/5] driver: add TXT driver in kernel Qiaowei Ren
2013-04-27 13:14 ` Greg Kroah-Hartman
2013-04-27 14:56 ` [PATCH 2/5] driver: provide sysfs interfaces to access TXT config space Qiaowei Ren
2013-04-27 14:56 ` [PATCH 3/5] driver: provide sysfs interfaces to access TXT log Qiaowei Ren
2013-04-27 13:17 ` Greg Kroah-Hartman [this message]
2013-04-27 14:56 ` [PATCH 4/5] driver: provide sysfs interfaces to access SMX parameter Qiaowei Ren
2013-04-27 14:56 ` [PATCH 5/5] driver: provide sysfs interfaces to access TXT heap Qiaowei Ren
[not found] <CAF0Lin0YUfDC4dPPrjjkFK5GRfJA4=o1Q5fPRmb7o1O-jph=4g@mail.gmail.com>
2013-04-29 14:01 ` [PATCH 3/5] driver: provide sysfs interfaces to access TXT log Greg KH
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20130427131715.GB32432@kroah.com \
--to=gregkh@linuxfoundation.org \
--cc=arnd@arndb.de \
--cc=gang.wei@intel.com \
--cc=linux-kernel@vger.kernel.org \
--cc=qiaowei.ren@intel.com \
--cc=richard.l.maliszewski@intel.com \
--cc=shane.wang@intel.com \
--cc=xiaoyan.zhang@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox