From: Stefan Richter <stefanr@s5r6.in-berlin.de>
To: Peter Hurley <peter@hurleysoftware.com>
Cc: linux1394-devel@lists.sourceforge.net, linux-kernel@vger.kernel.org
Subject: Re: [PATCH v2] firewire: Fix 'failed to read phy reg' on FW643 rev8
Date: Sun, 28 Apr 2013 14:15:59 +0200 [thread overview]
Message-ID: <20130428141559.0439c881@stein> (raw)
In-Reply-To: <1364307560-27601-1-git-send-email-peter@hurleysoftware.com>
On Mar 26 Peter Hurley wrote:
> --- a/drivers/firewire/ohci.c
> +++ b/drivers/firewire/ohci.c
> @@ -2268,8 +2268,8 @@ static int ohci_enable(struct fw_card *card,
> OHCI1394_HCControl_postedWriteEnable);
> flush_writes(ohci);
>
> - for (lps = 0, i = 0; !lps && i < 3; i++) {
> - msleep(50);
> + for (lps = 0, i = 0; !lps && i < 150; i++) {
> + msleep(1);
> lps = reg_read(ohci, OHCI1394_HCControlSet) &
> OHCI1394_HCControl_LPS;
> }
This duplicates a mistake (?) that we already did a few times elsewhere in
firewire-ohci: msleep(1) may put the thread to sleep for much, much longer
than 1 millisecond. I will propose a patch soon.
--
Stefan Richter
-=====-===-= -=-- ===--
http://arcgraph.de/sr/
next prev parent reply other threads:[~2013-04-28 12:16 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <1364306830.12229.14.camel@thor.lan>
2013-03-26 14:19 ` [PATCH v2] firewire: Fix 'failed to read phy reg' on FW643 rev8 Peter Hurley
2013-04-28 12:15 ` Stefan Richter [this message]
2013-04-28 21:07 ` Stefan Richter
2013-04-28 21:24 ` [PATCH v3] " Stefan Richter
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20130428141559.0439c881@stein \
--to=stefanr@s5r6.in-berlin.de \
--cc=linux-kernel@vger.kernel.org \
--cc=linux1394-devel@lists.sourceforge.net \
--cc=peter@hurleysoftware.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox