From: Jiri Olsa <jolsa@redhat.com>
To: Sukadev Bhattiprolu <sukadev@linux.vnet.ibm.com>
Cc: Arnaldo Carvalho de Melo <acme@ghostprotocols.net>,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH] perf: powerpc: Fix compile errors in bp_signal files
Date: Mon, 29 Apr 2013 11:59:25 +0200 [thread overview]
Message-ID: <20130429095925.GA1106@krava.brq.redhat.com> (raw)
In-Reply-To: <20130426173320.GA7029@us.ibm.com>
On Fri, Apr 26, 2013 at 10:33:21AM -0700, Sukadev Bhattiprolu wrote:
> From 0e27e218def9ae630cc07efbd21664c150a3727a Mon Sep 17 00:00:00 2001
> From: Sukadev Bhattiprolu <sukadev@linux.vnet.ibm.com>
> Date: Fri, 26 Apr 2013 10:17:56 -0700
> Subject: [PATCH] perf: powerpc: Fix compile errors in bp_signal files
>
> When building on powerpc, we get compile errors in bp_signal.c and
> bp_signal_overflow.c due to __u64 and '%llx'.
>
> Powerpc, needs __SANE_USERSPACE_TYPES__ to be defined so we pick up
> <asm-generic/int-ll64.h> and define __u64 as unsigned long long.
matches the use in tests/attr.c
Acked-by: Jiri Olsa <jolsa@redhat.com>
thanks,
jirka
>
> Signed-off-by: Sukadev Bhattiprolu <sukadev@linux.vnet.ibm.com>
> ---
> tools/perf/tests/bp_signal.c | 6 ++++++
> tools/perf/tests/bp_signal_overflow.c | 6 ++++++
> 2 files changed, 12 insertions(+), 0 deletions(-)
>
> diff --git a/tools/perf/tests/bp_signal.c b/tools/perf/tests/bp_signal.c
> index 68daa28..aba0954 100644
> --- a/tools/perf/tests/bp_signal.c
> +++ b/tools/perf/tests/bp_signal.c
> @@ -4,6 +4,12 @@
> * (git://github.com/deater/perf_event_tests)
> */
>
> +/*
> + * Powerpc needs __SANE_USERSPACE_TYPES__ before <linux/types.h> to select
> + * 'int-ll64.h' and avoid compile warnings when printing __u64 with %llu.
> + */
> +#define __SANE_USERSPACE_TYPES__
> +
> #include <stdlib.h>
> #include <stdio.h>
> #include <unistd.h>
> diff --git a/tools/perf/tests/bp_signal_overflow.c b/tools/perf/tests/bp_signal_overflow.c
> index fe7ed28..44ac821 100644
> --- a/tools/perf/tests/bp_signal_overflow.c
> +++ b/tools/perf/tests/bp_signal_overflow.c
> @@ -3,6 +3,12 @@
> * perf_event_tests (git://github.com/deater/perf_event_tests)
> */
>
> +/*
> + * Powerpc needs __SANE_USERSPACE_TYPES__ before <linux/types.h> to select
> + * 'int-ll64.h' and avoid compile warnings when printing __u64 with %llu.
> + */
> +#define __SANE_USERSPACE_TYPES__
> +
> #include <stdlib.h>
> #include <stdio.h>
> #include <unistd.h>
> --
> 1.7.1
>
next prev parent reply other threads:[~2013-04-29 9:59 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-04-26 17:33 [PATCH] perf: powerpc: Fix compile errors in bp_signal files Sukadev Bhattiprolu
2013-04-29 9:59 ` Jiri Olsa [this message]
2013-05-31 11:30 ` [tip:perf/core] perf tests: " tip-bot for Sukadev Bhattiprolu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20130429095925.GA1106@krava.brq.redhat.com \
--to=jolsa@redhat.com \
--cc=acme@ghostprotocols.net \
--cc=linux-kernel@vger.kernel.org \
--cc=sukadev@linux.vnet.ibm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox