Re: [PATCH 2/5] Add aix lvm partitions support files

[Karel Zak <kzak@redhat.com>]

On Mon, Apr 29, 2013 at 01:40:41PM +0200, Philippe De Muyter wrote:
> > why not memset(pps_found, ....)? I also see magical constant 16
> 
> Actually 16 is the maximum partition count allowed in a disk by linux,
> or should it be 15 ?  Is there already a constant for that ?
> The AIX disk I tested with had only :) 11 partitions.

I don't think it's correct to expect any hardcoded limit. 
 
The struct parsed_partitions->parts is allocated according to
disk_max_parts() where the limit depends on number of minor numbers or
it's DISK_MAX_PARTS (=256).

There is no problem to create disk with many partitions:

 # modprobe scsi_debug dev_size_mb=300
 # (echo -e 'g\n'; for i in {1..100}; do echo -e "n\n\n\n+1M"; done; \
    echo -e 'w\nq\n') | fdisk /dev/sdb

 # lsblk -n /dev/sdb | wc -l
 101

 Note it's fdisk with GPT support.

> > Philippe, do you have any disk image with AIX LVM? It would be nice to
> > have a way how to test the code. I'd like to add support for AIX to
> > libblkid too.
> 
> Of course.  But that's not a couple of blocks.  I'll try to cut the
> slice that you need.

 Cool!

    Karel

-- 
 Karel Zak  <kzak@redhat.com>
 http://karelzak.blogspot.com