public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
From: Greg KH <gregkh@linuxfoundation.org>
To: Andy Johnson <johnsonzjo@gmail.com>
Cc: linux-kernel@vger.kernel.org
Subject: Re: [PATCH 3/5] driver: provide sysfs interfaces to access TXT log
Date: Mon, 29 Apr 2013 07:01:54 -0700	[thread overview]
Message-ID: <20130429140154.GA18818@kroah.com> (raw)
In-Reply-To: <CAF0Lin0YUfDC4dPPrjjkFK5GRfJA4=o1Q5fPRmb7o1O-jph=4g@mail.gmail.com>

On Mon, Apr 29, 2013 at 04:47:41PM +0300, Andy Johnson wrote:
> Hello
>   
> >Oh, and NEVER use "raw" kobjects, by doing that, you know you are >doing
> something wrong in a driver.
> 
> May I ask a short question  what do you mean by  "raw" kobjects? do you mean
> that 
> 
> struct kobject *log_kobj;
> 
> is a local variable inside a method and thus this is not 
> 
> ok?

I mean "a driver should almost never touch a 'struct kobject' directly,
or define it as a variable to be used."

Use the driver core (i.e. 'struct device' and friends), and not 'struct
kobject'.

thanks,

greg k-h

       reply	other threads:[~2013-04-29 14:01 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <CAF0Lin0YUfDC4dPPrjjkFK5GRfJA4=o1Q5fPRmb7o1O-jph=4g@mail.gmail.com>
2013-04-29 14:01 ` Greg KH [this message]
2013-04-27 14:56 [PATCH 0/5] TXT driver Qiaowei Ren
2013-04-27 14:56 ` [PATCH 3/5] driver: provide sysfs interfaces to access TXT log Qiaowei Ren
2013-04-27 13:17   ` Greg Kroah-Hartman

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20130429140154.GA18818@kroah.com \
    --to=gregkh@linuxfoundation.org \
    --cc=johnsonzjo@gmail.com \
    --cc=linux-kernel@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox