Re: [patch 1/4] sched: Separate the scheduler entry for preemption

Christoph Hellwig
2011-06-22T18:43:36Z

On Wed, Jun 22, 2011 at 05:52:13PM -0000, Thomas Gleixner wrote:
> Block-IO and workqueues call into notifier functions from the
> scheduler core code with interrupts and preemption disabled. These
> calls should be made before entering the scheduler core.
>
> To simplify this, separate the scheduler core code into
> __schedule(). __schedule() is directly called from the places which
> set PREEMPT_ACTIVE and from schedule(). This allows us to add the work
> checks into schedule(), so they are only called when a task voluntary
> goes to sleep.

I don't think that works. We'll need to flush the block requests even
for an involuntary schedule.