From: Fabio Baltieri <fabio.baltieri@linaro.org>
To: Mark Brown <broonie@kernel.org>
Cc: Liam Girdwood <lgirdwood@gmail.com>,
alsa-devel@alsa-project.org, linux-kernel@vger.kernel.org,
Linus Walleij <linus.walleij@linaro.org>,
Lee Jones <lee.jones@linaro.org>,
Ola Lilja <ola.o.lilja@stericsson.com>
Subject: Re: [PATCH 2/3] ASoC: ux500: move clock controls to ab8500-codec
Date: Thu, 2 May 2013 09:54:21 +0200 [thread overview]
Message-ID: <20130502075421.GA23346@balto.lan> (raw)
In-Reply-To: <20130430183035.GC26160@sirena.org.uk>
On Tue, Apr 30, 2013 at 07:30:35PM +0100, Mark Brown wrote:
> On Tue, Apr 30, 2013 at 04:09:53PM +0200, Fabio Baltieri wrote:
> > Move ab8500 clock control definitions to the ab8500 codec driver,
> > leaving only card specific setting in mop500_ab8500_ctrls.
>
> So, if this is some generic thing and not some weird stuff for the card
> this really reopens the question about why this is done with user
> visible controls...
>
> > static struct snd_kcontrol_new ab8500_ctrls[] = {
> > + /* Digital interface - Clocks */
> > + SOC_SINGLE("Digital Interface Master Generator Switch",
> > + AB8500_DIGIFCONF1, AB8500_DIGIFCONF1_ENMASTGEN,
> > + 1, 0),
> > + SOC_SINGLE("Digital Interface 0 Bit-clock Switch",
> > + AB8500_DIGIFCONF1, AB8500_DIGIFCONF1_ENFSBITCLK0,
> > + 1, 0),
> > + SOC_SINGLE("Digital Interface 1 Bit-clock Switch",
> > + AB8500_DIGIFCONF1, AB8500_DIGIFCONF1_ENFSBITCLK1,
> > + 1, 0),
>
> ...this is all stuff that is normally figured out automatically by the
> drivers, we know when the audio interface is in use and hence when it
> needs to be clocked.
It makes sense, I'll poke the documentation I have and try to figure out
how to control those bits from a more appropriate place.
Thanks,
Fabio
--
Fabio Baltieri
next prev parent reply other threads:[~2013-05-02 7:54 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-04-30 14:09 [PATCH -next 0/3] mop500_ab8500 fixes Fabio Baltieri
2013-04-30 14:09 ` [PATCH 1/3] ASoC: dapm: use clk_prepare_enable and clk_disable_unprepare Fabio Baltieri
2013-04-30 18:31 ` Mark Brown
2013-04-30 14:09 ` [PATCH 2/3] ASoC: ux500: move clock controls to ab8500-codec Fabio Baltieri
2013-04-30 14:23 ` Lars-Peter Clausen
2013-04-30 18:30 ` Mark Brown
2013-05-02 7:54 ` Fabio Baltieri [this message]
2013-05-02 9:48 ` Fabio Baltieri
2013-05-02 9:52 ` [PATCH v2 2/3] ASoC: ux500: drop clock gating widgets from machine driver Fabio Baltieri
2013-05-03 9:42 ` Mark Brown
2013-04-30 14:09 ` [PATCH 3/3] ASoC: ux500: register controls to card instead of codec Fabio Baltieri
2013-04-30 18:33 ` Mark Brown
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20130502075421.GA23346@balto.lan \
--to=fabio.baltieri@linaro.org \
--cc=alsa-devel@alsa-project.org \
--cc=broonie@kernel.org \
--cc=lee.jones@linaro.org \
--cc=lgirdwood@gmail.com \
--cc=linus.walleij@linaro.org \
--cc=linux-kernel@vger.kernel.org \
--cc=ola.o.lilja@stericsson.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox