From: Peter Zijlstra <peterz@infradead.org>
To: Alex Shi <alex.shi@intel.com>
Cc: mingo@redhat.com, tglx@linutronix.de, akpm@linux-foundation.org,
arjan@linux.intel.com, bp@alien8.de, pjt@google.com,
namhyung@kernel.org, efault@gmx.de, morten.rasmussen@arm.com,
vincent.guittot@linaro.org, gregkh@linuxfoundation.org,
preeti@linux.vnet.ibm.com, viresh.kumar@linaro.org,
linux-kernel@vger.kernel.org, len.brown@intel.com,
rafael.j.wysocki@intel.com, jkosina@suse.cz,
clark.williams@gmail.com, tony.luck@intel.com,
keescook@chromium.org, mgorman@suse.de, riel@redhat.com
Subject: Re: [PATCH v4 6/6] sched: consider runnable load average in effective_load
Date: Thu, 2 May 2013 15:19:55 +0200 [thread overview]
Message-ID: <20130502131954.GH13837@dyad.programming.kicks-ass.net> (raw)
In-Reply-To: <1367040344-14485-7-git-send-email-alex.shi@intel.com>
> @@ -3120,6 +3124,7 @@ static int wake_affine(struct sched_domain *sd, struct task_struct *p, int sync)
> struct task_group *tg;
> unsigned long weight;
> int balanced;
> + int runnable_avg;
>
> idx = sd->wake_idx;
> this_cpu = smp_processor_id();
> @@ -3135,13 +3140,19 @@ static int wake_affine(struct sched_domain *sd, struct task_struct *p, int sync)
> if (sync) {
> tg = task_group(current);
> weight = current->se.load.weight;
> + runnable_avg = current->se.avg.runnable_avg_sum * NICE_0_LOAD
> + / (current->se.avg.runnable_avg_period + 1);
>
> - this_load += effective_load(tg, this_cpu, -weight, -weight);
> - load += effective_load(tg, prev_cpu, 0, -weight);
> + this_load += effective_load(tg, this_cpu, -weight, -weight)
> + * runnable_avg >> NICE_0_SHIFT;
> + load += effective_load(tg, prev_cpu, 0, -weight)
> + * runnable_avg >> NICE_0_SHIFT;
> }
I'm fairly sure this is wrong; but I haven't bothered to take pencil to paper.
I think you'll need to insert the runnable avg load and make sure
effective_load() uses the right sums itself.
next prev parent reply other threads:[~2013-05-02 13:21 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-04-27 5:25 [PATCH v4 0/6] sched: use runnable load based balance Alex Shi
2013-04-27 5:25 ` [PATCH v4 1/6] Revert "sched: Introduce temporary FAIR_GROUP_SCHED dependency for load-tracking" Alex Shi
2013-04-27 5:25 ` [PATCH v4 2/6] sched: set initial value of runnable avg for new forked task Alex Shi
2013-05-02 11:01 ` Peter Zijlstra
2013-04-27 5:25 ` [PATCH v4 3/6] sched: update cpu load after task_tick Alex Shi
2013-04-27 5:25 ` [PATCH v4 4/6] sched: compute runnable load avg in cpu_load and cpu_avg_load_per_task Alex Shi
2013-04-27 5:25 ` [PATCH v4 5/6] sched: consider runnable load average in move_tasks Alex Shi
2013-04-27 5:25 ` [PATCH v4 6/6] sched: consider runnable load average in effective_load Alex Shi
2013-05-02 13:19 ` Peter Zijlstra [this message]
2013-05-03 7:39 ` Alex Shi
2013-05-01 12:14 ` [PATCH v4 0/6] sched: use runnable load based balance Peter Zijlstra
2013-05-02 0:38 ` Alex Shi
2013-05-02 10:35 ` Peter Zijlstra
2013-05-03 7:55 ` Alex Shi
2013-05-03 8:54 ` Alex Shi
2013-05-07 7:51 ` Alex Shi
2013-05-08 16:11 ` Peter Zijlstra
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20130502131954.GH13837@dyad.programming.kicks-ass.net \
--to=peterz@infradead.org \
--cc=akpm@linux-foundation.org \
--cc=alex.shi@intel.com \
--cc=arjan@linux.intel.com \
--cc=bp@alien8.de \
--cc=clark.williams@gmail.com \
--cc=efault@gmx.de \
--cc=gregkh@linuxfoundation.org \
--cc=jkosina@suse.cz \
--cc=keescook@chromium.org \
--cc=len.brown@intel.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mgorman@suse.de \
--cc=mingo@redhat.com \
--cc=morten.rasmussen@arm.com \
--cc=namhyung@kernel.org \
--cc=pjt@google.com \
--cc=preeti@linux.vnet.ibm.com \
--cc=rafael.j.wysocki@intel.com \
--cc=riel@redhat.com \
--cc=tglx@linutronix.de \
--cc=tony.luck@intel.com \
--cc=vincent.guittot@linaro.org \
--cc=viresh.kumar@linaro.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox