From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1762271Ab3ECBRm (ORCPT ); Thu, 2 May 2013 21:17:42 -0400 Received: from nm26-vm0.access.bullet.mail.mud.yahoo.com ([66.94.236.225]:44546 "EHLO nm26-vm0.access.bullet.mail.mud.yahoo.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753698Ab3ECBRl (ORCPT ); Thu, 2 May 2013 21:17:41 -0400 X-Yahoo-Newman-Id: 949944.25276.bm@smtp105.sbc.mail.ne1.yahoo.com X-Yahoo-Newman-Property: ymail-3 X-YMail-OSG: JiP90EcVM1mbdg_6mB3famfykcWshfSqCix7ZWbP7z4vVQe jATpadsk72wIDJ12uD_f4jwQ_Nb1.3_qu7nJuHCV.v0SJ5HaBznDk2lRT.QI mNjlJ8d39uZHjziPUJTEnimSbB2Sp8qo3wjDHiZHLLOS9yK75qdx9fvokYB_ DEIt0PusB1NVf3.Pxnjjd7R1uphNrnpxYHOLJF.OexXnqTH2Kx_2DEFH3OnH VnXb5irWs_dx.5wRJMVvywMUf4TODwi6CH9xqL8AJaVN1YXTSMpY7O5N4x_V vyJPyh27erzkNCEtlGfY8bt2e1k1Rxv.FU9p9EfRBGsGJmDFHlOJY0AkAoxx ZElvLEiN9E2csYluvOrGXsBxfatcDUSOAayaSBlr6cKi3mq7V6P053wB.1ZM FZmlWrjF2t4L7FWcWyGMRkaE7HsOyO4Q8CEeOnVdYnuRPJV0a2Jq1DTIBujI 0XKk3GzOISJDGWURd3Y4TvDCxIiqV8bD1xHY- X-Yahoo-SMTP: zfeO.4KswBCc_PdwTE8HfYDCQ1aNmIcSvQHkDP4uSDBNBSXeKQ-- X-Rocket-Received: from localhost (linux@108.223.40.66 with plain) by smtp105.sbc.mail.ne1.yahoo.com with SMTP; 03 May 2013 01:17:39 +0000 UTC Date: Thu, 2 May 2013 18:17:41 -0700 From: Guenter Roeck To: Dirk Eibach Cc: linux-kernel@vger.kernel.org, Kumar Gala , Wim Van Sebroeck , linux-watchdog@vger.kernel.org, devicetree-discuss@lists.ozlabs.org Subject: Re: [PATCH] powerpc: Make Book E watchdog reset type configurable Message-ID: <20130503011741.GA23266@roeck-us.net> References: <1367505913-18970-1-git-send-email-dirk.eibach@gdsys.cc> <20130502161720.GA7797@roeck-us.net> <429ec64cf7c30a139db40eb20fd3e682@gdsys.cc> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <429ec64cf7c30a139db40eb20fd3e682@gdsys.cc> User-Agent: Mutt/1.5.21 (2010-09-15) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi Dirk, On Thu, May 02, 2013 at 09:11:19PM +0200, Dirk Eibach wrote: > Hi Guenter, > > >>diff --git a/drivers/watchdog/Kconfig b/drivers/watchdog/Kconfig > >>index e89fc31..6048593 100644 > >>--- a/drivers/watchdog/Kconfig > >>+++ b/drivers/watchdog/Kconfig > >>@@ -1172,6 +1172,38 @@ config BOOKE_WDT_DEFAULT_TIMEOUT > >> > >> The value can be overridden by the wdt_period command-line > >>parameter. > >> > >>+choice > >>+ prompt "PowerPC Book-E Watchdog reset type" > >>+ depends on BOOKE_WDT > >>+ default BOOKE_WDT_RESET_CHIP > >>+ help > >>+ Specify what kind of reset will be executed on watchdog timeout. > >>+ > >Seems to me it would be much better to make this configurable via > >platform data > >and/or device tree. > > good catch. What do the device-tree gurus think to be a nice > property name? > How about "reset-type" ? If that is not acceptable, a more device specific name might be "booke-reset-type". I would suggest to write a patch including property description and copy devicetree-discuss when you submit it. If devicetree works for your application, I would not bother with platform data. Btw, do you have an opinion about the timeout ? I'd like to get rid of the configuration parameter, as it is quite confusing (try to match the parameter to seconds on a Freescale processor and you'll understand what I mean). I asked about it on the list a while ago, but did not get any feedback. Thanks, Guenter