public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
From: Srinidhi Kasagar <srinidhi.kasagar@stericsson.com>
To: Jingoo Han <jg1.han@samsung.com>
Cc: "'Andrew Morton'" <akpm@linux-foundation.org>,
	"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
	"'Alessandro Zummo'" <a.zummo@towertech.it>,
	"rtc-linux@googlegroups.com" <rtc-linux@googlegroups.com>,
	Linus Walleij <linus.walleij@linaro.org>
Subject: Re: [PATCH 04/42] rtc: rtc-ab8500: remove unnecessary platform_set_drvdata()
Date: Fri, 3 May 2013 12:27:45 +0530	[thread overview]
Message-ID: <20130503065743.GA24864@bnru09> (raw)
In-Reply-To: <001201ce47c6$daecece0$90c6c6a0$@samsung.com>

On Fri, May 03, 2013 at 08:24:24 +0200, Jingoo Han wrote:
> The driver core clears the driver data to NULL after device_release
> or on probe failure, since commit 0998d0631001288a5974afc0b2a5f568bcdecb4d
> (device-core: Ensure drvdata = NULL when no driver is bound).
> Thus, it is not needed to manually clear the device driver data to NULL.
> 
> Signed-off-by: Jingoo Han <jg1.han@samsung.com>
> ---
>  drivers/rtc/rtc-ab8500.c |    2 --
>  1 files changed, 0 insertions(+), 2 deletions(-)
> 
> diff --git a/drivers/rtc/rtc-ab8500.c b/drivers/rtc/rtc-ab8500.c
> index 63cfa31..c5b62d4 100644
> --- a/drivers/rtc/rtc-ab8500.c
> +++ b/drivers/rtc/rtc-ab8500.c
> @@ -451,8 +451,6 @@ static int ab8500_rtc_remove(struct platform_device *pdev)
>  {
>  	ab8500_sysfs_rtc_unregister(&pdev->dev);
>  
> -	platform_set_drvdata(pdev, NULL);
> -
>  	return 0;
>  }
Ok, thanks. Hope you have taken care for the ab3100 too...

Acked-by:srinidhi kasagar <srinidhi.kasagar@stericsson.com>

regards/srinidhi 

  reply	other threads:[~2013-05-03  6:58 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-05-03  6:24 [PATCH 04/42] rtc: rtc-ab8500: remove unnecessary platform_set_drvdata() Jingoo Han
2013-05-03  6:57 ` Srinidhi Kasagar [this message]
2013-05-03  7:35   ` Jingoo Han

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20130503065743.GA24864@bnru09 \
    --to=srinidhi.kasagar@stericsson.com \
    --cc=a.zummo@towertech.it \
    --cc=akpm@linux-foundation.org \
    --cc=jg1.han@samsung.com \
    --cc=linus.walleij@linaro.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=rtc-linux@googlegroups.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox