From: Mark Brown <broonie@kernel.org>
To: Axel Lin <axel.lin@ingics.com>
Cc: Haojian Zhuang <haojian.zhuang@linaro.org>,
Milo Kim <milo.kim@ti.com>, Liam Girdwood <lgirdwood@gmail.com>,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH] regulator: Remove all platform_set_drvdata(pdev, NULL) in drivers
Date: Fri, 3 May 2013 14:19:08 +0100 [thread overview]
Message-ID: <20130503131908.GA3820@sirena.org.uk> (raw)
In-Reply-To: <1367585170.7397.1.camel@phoenix>
[-- Attachment #1: Type: text/plain, Size: 478 bytes --]
On Fri, May 03, 2013 at 08:46:10PM +0800, Axel Lin wrote:
> Since 0998d06310 "device-core: Ensure drvdata = NULL when no driver is bound",
> this is done by driver core after device_release or on probe failure.
> Thus we can remove all platform_set_drvdata(pdev, NULL) in drivers.
Applied, but note that this is nothing to do with the above commit - it
has always been a bug for drivers to rely on drvdata except while bound
so any driver that relied on clearing it was buggy.
[-- Attachment #2: Digital signature --]
[-- Type: application/pgp-signature, Size: 836 bytes --]
prev parent reply other threads:[~2013-05-03 13:19 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-05-03 12:46 [PATCH] regulator: Remove all platform_set_drvdata(pdev, NULL) in drivers Axel Lin
2013-05-03 13:19 ` Mark Brown [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20130503131908.GA3820@sirena.org.uk \
--to=broonie@kernel.org \
--cc=axel.lin@ingics.com \
--cc=haojian.zhuang@linaro.org \
--cc=lgirdwood@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=milo.kim@ti.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox