Re: Regression: ftdi_sio is slow (since Wed Oct 10 15:05:06 2012)

[Greg KH <gregkh@linuxfoundation.org>]

On Fri, May 03, 2013 at 07:02:46PM +0400, Stas Sergeev wrote:
> Hi.
> 
> We have a regression because of this patch:
> http://lkml.indiana.edu/hypermail/linux/kernel/1210.1/01456.html
> While it is arguably reasonable to have this for tcdrain or close,
> it also slows down poll/select a lot because n_tty_poll() does this:
> 
> tty_chars_in_buffer(tty) < WAKEUP_CHARS

What do you mean "slows down"?

> And it also slows down TIOCOUTQ ioctl I think (not measured).
> The slowdown of select() is big, the customer reports the inability
> to work that way.

Inability to work what way?

> Is this patch really needed? I mean, if the time to check TEMT is
> longer than to xmit that char, then what's the use?
> Or, if it is really a big deal, I guess it would be necessary to add
> a separate, .chars_in_buffer_fast method.

We need some way to check the chars in the buffer, is the device you are
using just very slow to respond to this request?  How slow?  Do you have
a test case that we can see how it is affected?

thanks,

greg k-h