Re: [PATCH -v7 10/11] arm, change reboot_mode to use enum reboot_mode

Ingo Molnar
2013-05-02T07:30:27Z

* Robin Holt <holt@sgi.com> wrote:

> #ifndef __ASSEMBLY__
>
> #include <linux/types.h>
> +#include <linux/reboot.h>
>
> void iop3xx_map_io(void);
> void iop_init_cp6_handler(void);
> void iop_init_time(unsigned long tickrate);
> -void iop3xx_restart(char, const char *);
> +void iop3xx_restart(enum reboot_mode, const char *);

IMO the introduction of the enum is making things cleaner here all around.

As long as it's an equivalent transformation for ARM with no reduction in
functionality (i.e. please fix any bugs Russell found), this all looks
like a nice series.

Is there no parameter namespace clash between reboot modifier strings on
various architectures? I.e. 's' meaning something on x86 and meaning a
different thing on ARM or some other architecture.

Thanks,

Ingo