From: Dan Carpenter <dan.carpenter@oracle.com>
To: Jake Champlin <jake.champlin.27@gmail.com>
Cc: willy@meta-x.org, gregkh@linuxfoundation.org,
yamanetoshi@gmail.com, adam.buchbinder@gmail.com,
peterhuewe@gmx.de, fengguang.wu@intel.com,
devel@driverdev.osuosl.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] Staging: Panel: panel: Fixed checkpatch line length warnings
Date: Sun, 5 May 2013 16:06:40 +0300 [thread overview]
Message-ID: <20130505130640.GA4686@mwanda> (raw)
In-Reply-To: <20130504152058.GA20790@gmail.com>
On Sat, May 04, 2013 at 11:21:17AM -0400, Jake Champlin wrote:
> @@ -1802,10 +1803,11 @@ static inline void input_state_falling(struct logical_input *input)
>
> if (input->u.kbd.repeat_str[0]) {
> char *repeat_str = input->u.kbd.repeat_str;
> - if (input->high_timer >= KEYPAD_REP_START)
> + if (input->high_timer >= KEYPAD_REP_START) {
> + int s = sizeof(input->u.kbd.repeat_str);
> input->high_timer -= KEYPAD_REP_DELAY;
> - keypad_send_key(repeat_str,
> - sizeof(input->u.kbd.repeat_str));
> + keypad_send_key(repeat_str, s);
> + }
This looks like a bugfix. Good job. Please mention bug fixes in
the changelog next time.
regards,
dan carpenter
prev parent reply other threads:[~2013-05-05 13:07 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-05-04 15:21 [PATCH] Staging: Panel: panel: Fixed checkpatch line length warnings Jake Champlin
2013-05-04 16:52 ` Willy Tarreau
2013-05-05 13:06 ` Dan Carpenter [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20130505130640.GA4686@mwanda \
--to=dan.carpenter@oracle.com \
--cc=adam.buchbinder@gmail.com \
--cc=devel@driverdev.osuosl.org \
--cc=fengguang.wu@intel.com \
--cc=gregkh@linuxfoundation.org \
--cc=jake.champlin.27@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=peterhuewe@gmx.de \
--cc=willy@meta-x.org \
--cc=yamanetoshi@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox