* [PATCH 1/8] mfd: intel_msic: remove unnecessary platform_set_drvdata()
@ 2013-05-06 4:04 Jingoo Han
2013-05-06 7:04 ` 'Mika Westerberg'
` (2 more replies)
0 siblings, 3 replies; 5+ messages in thread
From: Jingoo Han @ 2013-05-06 4:04 UTC (permalink / raw)
To: 'Samuel Ortiz'
Cc: linux-kernel, 'Jingoo Han', 'Mika Westerberg'
The driver core clears the driver data to NULL after device_release
or on probe failure, since commit 0998d0631001288a5974afc0b2a5f568bcdecb4d
(device-core: Ensure drvdata = NULL when no driver is bound).
Thus, it is not needed to manually clear the device driver data to NULL.
Signed-off-by: Jingoo Han <jg1.han@samsung.com>
---
drivers/mfd/intel_msic.c | 1 -
1 files changed, 0 insertions(+), 1 deletions(-)
diff --git a/drivers/mfd/intel_msic.c b/drivers/mfd/intel_msic.c
index 5be3b5e..977506e 100644
--- a/drivers/mfd/intel_msic.c
+++ b/drivers/mfd/intel_msic.c
@@ -443,7 +443,6 @@ static int intel_msic_remove(struct platform_device *pdev)
struct intel_msic *msic = platform_get_drvdata(pdev);
intel_msic_remove_devices(msic);
- platform_set_drvdata(pdev, NULL);
return 0;
}
--
1.7.2.5
^ permalink raw reply related [flat|nested] 5+ messages in thread* Re: [PATCH 1/8] mfd: intel_msic: remove unnecessary platform_set_drvdata()
2013-05-06 4:04 [PATCH 1/8] mfd: intel_msic: remove unnecessary platform_set_drvdata() Jingoo Han
@ 2013-05-06 7:04 ` 'Mika Westerberg'
2013-05-06 7:11 ` Jingoo Han
2013-05-07 8:14 ` Lee Jones
2013-05-16 22:16 ` Samuel Ortiz
2 siblings, 1 reply; 5+ messages in thread
From: 'Mika Westerberg' @ 2013-05-06 7:04 UTC (permalink / raw)
To: Jingoo Han; +Cc: 'Samuel Ortiz', linux-kernel
On Mon, May 06, 2013 at 01:04:25PM +0900, Jingoo Han wrote:
> The driver core clears the driver data to NULL after device_release
> or on probe failure, since commit 0998d0631001288a5974afc0b2a5f568bcdecb4d
> (device-core: Ensure drvdata = NULL when no driver is bound).
> Thus, it is not needed to manually clear the device driver data to NULL.
>
> Signed-off-by: Jingoo Han <jg1.han@samsung.com>
Acked-by: Mika Westerberg <mika.westerberg@linux.intel.com>
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH 1/8] mfd: intel_msic: remove unnecessary platform_set_drvdata()
2013-05-06 7:04 ` 'Mika Westerberg'
@ 2013-05-06 7:11 ` Jingoo Han
0 siblings, 0 replies; 5+ messages in thread
From: Jingoo Han @ 2013-05-06 7:11 UTC (permalink / raw)
To: 'Mika Westerberg'
Cc: 'Samuel Ortiz', linux-kernel, Jingoo Han
On Monday, May 06, 2013 4:04 PM, Mika Westerberg wrote:
> On Mon, May 06, 2013 at 01:04:25PM +0900, Jingoo Han wrote:
> > The driver core clears the driver data to NULL after device_release
> > or on probe failure, since commit 0998d0631001288a5974afc0b2a5f568bcdecb4d
> > (device-core: Ensure drvdata = NULL when no driver is bound).
> > Thus, it is not needed to manually clear the device driver data to NULL.
> >
> > Signed-off-by: Jingoo Han <jg1.han@samsung.com>
>
> Acked-by: Mika Westerberg <mika.westerberg@linux.intel.com>
Hi Mika Westerberg,
Thank you for your Acked-by. :)
It is very helpuful.
Best regards,
Jingoo Han
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH 1/8] mfd: intel_msic: remove unnecessary platform_set_drvdata()
2013-05-06 4:04 [PATCH 1/8] mfd: intel_msic: remove unnecessary platform_set_drvdata() Jingoo Han
2013-05-06 7:04 ` 'Mika Westerberg'
@ 2013-05-07 8:14 ` Lee Jones
2013-05-16 22:16 ` Samuel Ortiz
2 siblings, 0 replies; 5+ messages in thread
From: Lee Jones @ 2013-05-07 8:14 UTC (permalink / raw)
To: Jingoo Han
Cc: 'Samuel Ortiz', linux-kernel, 'Mika Westerberg'
On Mon, 06 May 2013, Jingoo Han wrote:
> The driver core clears the driver data to NULL after device_release
> or on probe failure, since commit 0998d0631001288a5974afc0b2a5f568bcdecb4d
> (device-core: Ensure drvdata = NULL when no driver is bound).
> Thus, it is not needed to manually clear the device driver data to NULL.
>
> Signed-off-by: Jingoo Han <jg1.han@samsung.com>
> ---
> drivers/mfd/intel_msic.c | 1 -
> 1 files changed, 0 insertions(+), 1 deletions(-)
>
> diff --git a/drivers/mfd/intel_msic.c b/drivers/mfd/intel_msic.c
> index 5be3b5e..977506e 100644
> --- a/drivers/mfd/intel_msic.c
> +++ b/drivers/mfd/intel_msic.c
> @@ -443,7 +443,6 @@ static int intel_msic_remove(struct platform_device *pdev)
> struct intel_msic *msic = platform_get_drvdata(pdev);
>
> intel_msic_remove_devices(msic);
> - platform_set_drvdata(pdev, NULL);
>
> return 0;
> }
For the set:
Acked-by: Lee Jones <lee.jones@linaro.org>
--
Lee Jones
Linaro ST-Ericsson Landing Team Lead
Linaro.org │ Open source software for ARM SoCs
Follow Linaro: Facebook | Twitter | Blog
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH 1/8] mfd: intel_msic: remove unnecessary platform_set_drvdata()
2013-05-06 4:04 [PATCH 1/8] mfd: intel_msic: remove unnecessary platform_set_drvdata() Jingoo Han
2013-05-06 7:04 ` 'Mika Westerberg'
2013-05-07 8:14 ` Lee Jones
@ 2013-05-16 22:16 ` Samuel Ortiz
2 siblings, 0 replies; 5+ messages in thread
From: Samuel Ortiz @ 2013-05-16 22:16 UTC (permalink / raw)
To: Jingoo Han; +Cc: linux-kernel, 'Mika Westerberg'
Hi Jingoo,
On Mon, May 06, 2013 at 01:04:25PM +0900, Jingoo Han wrote:
> The driver core clears the driver data to NULL after device_release
> or on probe failure, since commit 0998d0631001288a5974afc0b2a5f568bcdecb4d
> (device-core: Ensure drvdata = NULL when no driver is bound).
> Thus, it is not needed to manually clear the device driver data to NULL.
>
> Signed-off-by: Jingoo Han <jg1.han@samsung.com>
> ---
> drivers/mfd/intel_msic.c | 1 -
> 1 files changed, 0 insertions(+), 1 deletions(-)
All 8 patches applied to mfd-next.
Cheers,
Samuel.
--
Intel Open Source Technology Centre
http://oss.intel.com/
^ permalink raw reply [flat|nested] 5+ messages in thread
end of thread, other threads:[~2013-05-16 22:16 UTC | newest]
Thread overview: 5+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2013-05-06 4:04 [PATCH 1/8] mfd: intel_msic: remove unnecessary platform_set_drvdata() Jingoo Han
2013-05-06 7:04 ` 'Mika Westerberg'
2013-05-06 7:11 ` Jingoo Han
2013-05-07 8:14 ` Lee Jones
2013-05-16 22:16 ` Samuel Ortiz
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox