Re: [PATCHv2 0/2] sched: move content out of core files for load calculations

Paul Gortmaker
2013-05-06T14:20:08Z

[Re: [PATCHv2 0/2] sched: move content out of core files for load calculations] On 06/05/2013 (Mon 11:26) Ingo Molnar wrote:

>
> * Ingo Molnar <mingo@kernel.org> wrote:
>
> >
> > * Paul Gortmaker <paul.gortmaker@windriver.com> wrote:
> >
> > > Recent activity has had a focus on moving functionally related blocks of
> > > stuff out of sched/core.c into stand-alone files. The code relating to load
> > > calculations has grown significantly enough recently to warrant placing it in
> > > a separate file.
> > >
> > > Here we do that, and in doing so, we shed ~20k of code from sched/core.c (~10%).
> > >
> > > A couple small static functions in the core sched.h header were also localized
> > > to their singular user in sched/fair.c at the same time, with the goal to also
> > > reduce the amount of "broadcast" content in that sched.h file.
> > >
> > > Paul.
> > > ---
> > >
> > > v2 changes:
> > >
> > > 1) rebase from tip's sched/core (v3.9-rc1-38-gb329fd5) to today's
> > > tip master (v3.9-rc6-2031-g27f8b76).
> > > 2) rename file from load_avg.c to proc.c
> >
> > Thanks, looks good to me. Note, I'll try to apply this after the initial
> > round of trees went to Linus in the merge window, to reduce interactions
> > between the trees. [...]
>
> Ok, all relevant trees are now upstream - mind sending a refreshed series
> against upstream merge commit 534c97b0950b or later?

Sure. After putting them on top of 534c97b095, I re-checked with a
quick defconfig build. Also in comparison to v2, the patches are
unchanged except for trivial line offset deltas. So it should be OK.

Thanks,
Paul.

---

The following changes since commit 534c97b0950b1967bca1c753aeaed32f5db40264:

Merge branch 'timers-nohz-for-linus' of git://git.kernel.org/pub/scm/linux/kernel/git/tip/tip (2013-05-05 13:23:27 -0700)

are available in the git repository at:

git://git.kernel.org/pub/scm/linux/kernel/git/paulg/linux.git for-ingo

for you to fetch changes up to 54aecbbcfcbea684257ebe674251f148ee340412:

sched: move update_load_[add/sub/set] from sched.h to fair.c (2013-05-06 09:39:50 -0400)

----------------------------------------------------------------
Paul Gortmaker (2):
sched: fork load calculation code from sched/core --> sched/proc
sched: move update_load_[add/sub/set] from sched.h to fair.c

kernel/sched/Makefile | 2 +-
kernel/sched/core.c | 569 -------------------------------------------------
kernel/sched/fair.c | 18 ++
kernel/sched/proc.c | 578 ++++++++++++++++++++++++++++++++++++++++++++++++++
kernel/sched/sched.h | 26 +--
5 files changed, 605 insertions(+), 588 deletions(-)
create mode 100644 kernel/sched/proc.c