* [PATCH] power_supply: wm831x_backup: Remove kfree call for devdata->backup.name
@ 2013-05-04 5:57 Axel Lin
2013-05-06 10:34 ` Mark Brown
0 siblings, 1 reply; 3+ messages in thread
From: Axel Lin @ 2013-05-04 5:57 UTC (permalink / raw)
To: Anton Vorontsov; +Cc: Mark Brown, David Woodhouse, linux-kernel
devdata->backup.name points to devdata->name, the memory for devdata->name is
part of struct wm831x_backup. Thus remove kfree call for devdata->backup.name.
Signed-off-by: Axel Lin <axel.lin@ingics.com>
---
drivers/power/wm831x_backup.c | 1 -
1 file changed, 1 deletion(-)
diff --git a/drivers/power/wm831x_backup.c b/drivers/power/wm831x_backup.c
index 58cbb00..56fb509 100644
--- a/drivers/power/wm831x_backup.c
+++ b/drivers/power/wm831x_backup.c
@@ -207,7 +207,6 @@ static int wm831x_backup_remove(struct platform_device *pdev)
struct wm831x_backup *devdata = platform_get_drvdata(pdev);
power_supply_unregister(&devdata->backup);
- kfree(devdata->backup.name);
return 0;
}
--
1.8.1.2
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH] power_supply: wm831x_backup: Remove kfree call for devdata->backup.name
2013-05-04 5:57 [PATCH] power_supply: wm831x_backup: Remove kfree call for devdata->backup.name Axel Lin
@ 2013-05-06 10:34 ` Mark Brown
2013-05-10 18:58 ` Anton Vorontsov
0 siblings, 1 reply; 3+ messages in thread
From: Mark Brown @ 2013-05-06 10:34 UTC (permalink / raw)
To: Axel Lin; +Cc: Anton Vorontsov, David Woodhouse, linux-kernel
[-- Attachment #1: Type: text/plain, Size: 279 bytes --]
On Sat, May 04, 2013 at 01:57:55PM +0800, Axel Lin wrote:
> devdata->backup.name points to devdata->name, the memory for devdata->name is
> part of struct wm831x_backup. Thus remove kfree call for devdata->backup.name.
Acked-by: Mark Brown <broonie@opensource.wolfsonmicro.com>
[-- Attachment #2: Digital signature --]
[-- Type: application/pgp-signature, Size: 836 bytes --]
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] power_supply: wm831x_backup: Remove kfree call for devdata->backup.name
2013-05-06 10:34 ` Mark Brown
@ 2013-05-10 18:58 ` Anton Vorontsov
0 siblings, 0 replies; 3+ messages in thread
From: Anton Vorontsov @ 2013-05-10 18:58 UTC (permalink / raw)
To: Mark Brown; +Cc: Axel Lin, David Woodhouse, linux-kernel
On Mon, May 06, 2013 at 11:34:48AM +0100, Mark Brown wrote:
> On Sat, May 04, 2013 at 01:57:55PM +0800, Axel Lin wrote:
> > devdata->backup.name points to devdata->name, the memory for devdata->name is
> > part of struct wm831x_backup. Thus remove kfree call for devdata->backup.name.
>
> Acked-by: Mark Brown <broonie@opensource.wolfsonmicro.com>
Applied, thanks a lot!
Anton
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2013-05-10 19:48 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2013-05-04 5:57 [PATCH] power_supply: wm831x_backup: Remove kfree call for devdata->backup.name Axel Lin
2013-05-06 10:34 ` Mark Brown
2013-05-10 18:58 ` Anton Vorontsov
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox