From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S933277Ab3EGE3q (ORCPT ); Tue, 7 May 2013 00:29:46 -0400 Received: from hrndva-omtalb.mail.rr.com ([71.74.56.122]:25931 "EHLO hrndva-omtalb.mail.rr.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S932634Ab3EGEZ6 (ORCPT ); Tue, 7 May 2013 00:25:58 -0400 X-Authority-Analysis: v=2.0 cv=cOZiQyiN c=1 sm=0 a=rXTBtCOcEpjy1lPqhTCpEQ==:17 a=mNMOxpOpBa8A:10 a=Ciwy3NGCPMMA:10 a=hpCxM3PgToIA:10 a=5SG0PmZfjMsA:10 a=bbbx4UPp9XUA:10 a=meVymXHHAAAA:8 a=ooEfGZWIN5MA:10 a=pGLkceISAAAA:8 a=cm27Pg_UAAAA:8 a=drOt6m5kAAAA:8 a=20KFwNOVAAAA:8 a=PtDNVHqPAAAA:8 a=DfNHnWVPAAAA:8 a=VwQbUJbxAAAA:8 a=Z4Rwk6OoAAAA:8 a=fC4T7qsy4_4xvlMS5R0A:9 a=MSl-tDqOz04A:10 a=zv9_9hqRWm8A:10 a=jEp0ucaQiEUA:10 a=wYE_KDyynt4A:10 a=lBRciGGoxdUA:10 a=jbrJJM5MRmoA:10 a=jeBq3FmKZ4MA:10 a=rXTBtCOcEpjy1lPqhTCpEQ==:117 X-Cloudmark-Score: 0 X-Authenticated-User: X-Originating-IP: 74.67.115.198 Message-Id: <20130507035851.742899058@goodmis.org> User-Agent: quilt/0.60-1 Date: Mon, 06 May 2013 23:58:17 -0400 From: Steven Rostedt To: linux-kernel@vger.kernel.org, stable@vger.kernel.org Cc: Emese Revfy , PaX Team , Kees Cook , Al Viro , Oleg Nesterov , "Eric W. Biederman" , Serge Hallyn , Andrew Morton Subject: [065/126] kernel/signal.c: stop info leak via the tkill and the tgkill syscalls References: <20130507035712.909872333@goodmis.org> Content-Disposition: inline; filename=0065-kernel-signal.c-stop-info-leak-via-the-tkill-and-the.patch Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org 3.6.11.3 stable review patch. If anyone has any objections, please let me know. ------------------ From: Emese Revfy [ Upstream commit b9e146d8eb3b9ecae5086d373b50fa0c1f3e7f0f ] This fixes a kernel memory contents leak via the tkill and tgkill syscalls for compat processes. This is visible in the siginfo_t->_sifields._rt.si_sigval.sival_ptr field when handling signals delivered from tkill. The place of the infoleak: int copy_siginfo_to_user32(compat_siginfo_t __user *to, siginfo_t *from) { ... put_user_ex(ptr_to_compat(from->si_ptr), &to->si_ptr); ... } Signed-off-by: Emese Revfy Reviewed-by: PaX Team Signed-off-by: Kees Cook Cc: Al Viro Cc: Oleg Nesterov Cc: "Eric W. Biederman" Cc: Serge Hallyn Cc: Signed-off-by: Andrew Morton Signed-off-by: Linus Torvalds Signed-off-by: Steven Rostedt --- kernel/signal.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/kernel/signal.c b/kernel/signal.c index be4f856..6b9b817 100644 --- a/kernel/signal.c +++ b/kernel/signal.c @@ -2898,7 +2898,7 @@ do_send_specific(pid_t tgid, pid_t pid, int sig, struct siginfo *info) static int do_tkill(pid_t tgid, pid_t pid, int sig) { - struct siginfo info; + struct siginfo info = {}; info.si_signo = sig; info.si_errno = 0; -- 1.7.10.4