Re: [PATCH 1/8] mfd: intel_msic: remove unnecessary platform_set_drvdata()

[Lee Jones <lee.jones@linaro.org>]

On Mon, 06 May 2013, Jingoo Han wrote:

> The driver core clears the driver data to NULL after device_release
> or on probe failure, since commit 0998d0631001288a5974afc0b2a5f568bcdecb4d
> (device-core: Ensure drvdata = NULL when no driver is bound).
> Thus, it is not needed to manually clear the device driver data to NULL.
> 
> Signed-off-by: Jingoo Han <jg1.han@samsung.com>
> ---
>  drivers/mfd/intel_msic.c |    1 -
>  1 files changed, 0 insertions(+), 1 deletions(-)
> 
> diff --git a/drivers/mfd/intel_msic.c b/drivers/mfd/intel_msic.c
> index 5be3b5e..977506e 100644
> --- a/drivers/mfd/intel_msic.c
> +++ b/drivers/mfd/intel_msic.c
> @@ -443,7 +443,6 @@ static int intel_msic_remove(struct platform_device *pdev)
>  	struct intel_msic *msic = platform_get_drvdata(pdev);
>  
>  	intel_msic_remove_devices(msic);
> -	platform_set_drvdata(pdev, NULL);
>  
>  	return 0;
>  }

For the set:

Acked-by: Lee Jones <lee.jones@linaro.org>

-- 
Lee Jones
Linaro ST-Ericsson Landing Team Lead
Linaro.org │ Open source software for ARM SoCs
Follow Linaro: Facebook | Twitter | Blog