From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1758752Ab3EGIQP (ORCPT ); Tue, 7 May 2013 04:16:15 -0400 Received: from mail-we0-f181.google.com ([74.125.82.181]:45391 "EHLO mail-we0-f181.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1758167Ab3EGIQM (ORCPT ); Tue, 7 May 2013 04:16:12 -0400 Date: Tue, 7 May 2013 09:16:03 +0100 From: Lee Jones To: Jingoo Han Cc: "'Grant Likely'" , "'Linus Walleij'" , linux-kernel@vger.kernel.org Subject: Re: [PATCH 5/7] gpio: tc3589x: remove unnecessary platform_set_drvdata() Message-ID: <20130507081603.GC3102@gmail.com> References: <001b01ce4a0a$5076bb90$f16432b0$@samsung.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <001b01ce4a0a$5076bb90$f16432b0$@samsung.com> User-Agent: Mutt/1.5.21 (2010-09-15) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Mon, 06 May 2013, Jingoo Han wrote: > The driver core clears the driver data to NULL after device_release > or on probe failure, since commit 0998d0631001288a5974afc0b2a5f568bcdecb4d > (device-core: Ensure drvdata = NULL when no driver is bound). > Thus, it is not needed to manually clear the device driver data to NULL. > > Signed-off-by: Jingoo Han > --- > drivers/gpio/gpio-tc3589x.c | 1 - > 1 files changed, 0 insertions(+), 1 deletions(-) > > diff --git a/drivers/gpio/gpio-tc3589x.c b/drivers/gpio/gpio-tc3589x.c > index d34d80d..4a5de27 100644 > --- a/drivers/gpio/gpio-tc3589x.c > +++ b/drivers/gpio/gpio-tc3589x.c > @@ -407,7 +407,6 @@ static int tc3589x_gpio_remove(struct platform_device *pdev) > > free_irq(irq, tc3589x_gpio); > > - platform_set_drvdata(pdev, NULL); > kfree(tc3589x_gpio); > > return 0; Acked-by: Lee Jones -- Lee Jones Linaro ST-Ericsson Landing Team Lead Linaro.org │ Open source software for ARM SoCs Follow Linaro: Facebook | Twitter | Blog