From: "J. Bruce Fields" <bfields@fieldses.org>
To: Zhao Hongjiang <zhaohongjiang@huawei.com>
Cc: bfields@redhat.com, linux-nfs@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH] nfsd: get rid of the unused functions in vfs
Date: Tue, 7 May 2013 17:05:00 -0400 [thread overview]
Message-ID: <20130507210500.GG32743@fieldses.org> (raw)
In-Reply-To: <51838C98.2090205@huawei.com>
Thanks, applying for 3.11.
--b.
On Fri, May 03, 2013 at 06:08:24PM +0800, Zhao Hongjiang wrote:
> The fh_lock_parent(), nfsd_truncate(), nfsd_notify_change() and nfsd_sync_dir()
> fuctions were never implement and used, just remove them.
>
> Signed-off-by: Zhao Hongjiang <zhaohongjiang@huawei.com>
> ---
> fs/nfsd/vfs.h | 5 -----
> 1 files changed, 0 insertions(+), 5 deletions(-)
>
> diff --git a/fs/nfsd/vfs.h b/fs/nfsd/vfs.h
> index 5b58941..8d2b40d 100644
> --- a/fs/nfsd/vfs.h
> +++ b/fs/nfsd/vfs.h
> @@ -39,7 +39,6 @@
> typedef int (*nfsd_dirop_t)(struct inode *, struct dentry *, int, int);
>
> /* nfsd/vfs.c */
> -int fh_lock_parent(struct svc_fh *, struct dentry *);
> int nfsd_racache_init(int);
> void nfsd_racache_shutdown(void);
> int nfsd_cross_mnt(struct svc_rqst *rqstp, struct dentry **dpp,
> @@ -92,17 +91,13 @@ __be32 nfsd_remove(struct svc_rqst *,
> struct svc_fh *, char *, int);
> __be32 nfsd_unlink(struct svc_rqst *, struct svc_fh *, int type,
> char *name, int len);
> -int nfsd_truncate(struct svc_rqst *, struct svc_fh *,
> - unsigned long size);
> __be32 nfsd_readdir(struct svc_rqst *, struct svc_fh *,
> loff_t *, struct readdir_cd *, filldir_t);
> __be32 nfsd_statfs(struct svc_rqst *, struct svc_fh *,
> struct kstatfs *, int access);
>
> -int nfsd_notify_change(struct inode *, struct iattr *);
> __be32 nfsd_permission(struct svc_rqst *, struct svc_export *,
> struct dentry *, int);
> -int nfsd_sync_dir(struct dentry *dp);
>
> #if defined(CONFIG_NFSD_V2_ACL) || defined(CONFIG_NFSD_V3_ACL)
> struct posix_acl *nfsd_get_posix_acl(struct svc_fh *, int);
> --
> 1.7.1
>
prev parent reply other threads:[~2013-05-07 21:05 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-05-03 10:08 [PATCH] nfsd: get rid of the unused functions in vfs Zhao Hongjiang
2013-05-07 21:05 ` J. Bruce Fields [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20130507210500.GG32743@fieldses.org \
--to=bfields@fieldses.org \
--cc=bfields@redhat.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-nfs@vger.kernel.org \
--cc=zhaohongjiang@huawei.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox