public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
* [PATCH] mfd: MFD_TPS65912 needs MFD_CORE
@ 2013-04-19 12:05 Michal Marek
  2013-05-07 21:41 ` Borislav Petkov
  2013-05-16 22:13 ` Samuel Ortiz
  0 siblings, 2 replies; 3+ messages in thread
From: Michal Marek @ 2013-04-19 12:05 UTC (permalink / raw)
  To: Samuel Ortiz; +Cc: linux-kernel

With MFD_TPS65912=y and MFD_CORE=m/n, the build fails with

drivers/mfd/tps65912-core.c:147: undefined reference to `mfd_add_devices'
drivers/mfd/tps65912-core.c:164: undefined reference to `mfd_remove_devices'
drivers/mfd/tps65912-core.c:171: undefined reference to `mfd_remove_devices'

Signed-off-by: Michal Marek <mmarek@suse.cz>
---
 drivers/mfd/Kconfig | 1 +
 1 file changed, 1 insertion(+)

diff --git a/drivers/mfd/Kconfig b/drivers/mfd/Kconfig
index 60611cd..5faf7c2 100644
--- a/drivers/mfd/Kconfig
+++ b/drivers/mfd/Kconfig
@@ -805,6 +805,7 @@ config MFD_TPS65910
 config MFD_TPS65912
 	bool "TI TPS65912 Power Management chip"
 	depends on GPIOLIB
+	select MFD_CORE
 	help
 	  If you say yes here you get support for the TPS65912 series of
 	  PM chips.
-- 
1.8.2.1


^ permalink raw reply related	[flat|nested] 3+ messages in thread

* Re: [PATCH] mfd: MFD_TPS65912 needs MFD_CORE
  2013-04-19 12:05 [PATCH] mfd: MFD_TPS65912 needs MFD_CORE Michal Marek
@ 2013-05-07 21:41 ` Borislav Petkov
  2013-05-16 22:13 ` Samuel Ortiz
  1 sibling, 0 replies; 3+ messages in thread
From: Borislav Petkov @ 2013-05-07 21:41 UTC (permalink / raw)
  To: Michal Marek; +Cc: Samuel Ortiz, linux-kernel

On Fri, Apr 19, 2013 at 02:05:56PM +0200, Michal Marek wrote:
> With MFD_TPS65912=y and MFD_CORE=m/n, the build fails with
> 
> drivers/mfd/tps65912-core.c:147: undefined reference to `mfd_add_devices'
> drivers/mfd/tps65912-core.c:164: undefined reference to `mfd_remove_devices'
> drivers/mfd/tps65912-core.c:171: undefined reference to `mfd_remove_devices'
> 
> Signed-off-by: Michal Marek <mmarek@suse.cz>

Acked-by: Borislav Petkov <bp@suse.de>

Looks like this one is not upstream yet - just triggered it on a
randconfig build of current linus.

-- 
Regards/Gruss,
    Boris.

Sent from a fat crate under my desk. Formatting is fine.
--

^ permalink raw reply	[flat|nested] 3+ messages in thread

* Re: [PATCH] mfd: MFD_TPS65912 needs MFD_CORE
  2013-04-19 12:05 [PATCH] mfd: MFD_TPS65912 needs MFD_CORE Michal Marek
  2013-05-07 21:41 ` Borislav Petkov
@ 2013-05-16 22:13 ` Samuel Ortiz
  1 sibling, 0 replies; 3+ messages in thread
From: Samuel Ortiz @ 2013-05-16 22:13 UTC (permalink / raw)
  To: Michal Marek; +Cc: linux-kernel

Hi Marek,

On Fri, Apr 19, 2013 at 02:05:56PM +0200, Michal Marek wrote:
> With MFD_TPS65912=y and MFD_CORE=m/n, the build fails with
> 
> drivers/mfd/tps65912-core.c:147: undefined reference to `mfd_add_devices'
> drivers/mfd/tps65912-core.c:164: undefined reference to `mfd_remove_devices'
> drivers/mfd/tps65912-core.c:171: undefined reference to `mfd_remove_devices'
> 
> Signed-off-by: Michal Marek <mmarek@suse.cz>
> ---
>  drivers/mfd/Kconfig | 1 +
>  1 file changed, 1 insertion(+)
This one is on my mfd-fixes tree already, thanks.

Cheers,
Samuel.

-- 
Intel Open Source Technology Centre
http://oss.intel.com/

^ permalink raw reply	[flat|nested] 3+ messages in thread

end of thread, other threads:[~2013-05-16 22:13 UTC | newest]

Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2013-04-19 12:05 [PATCH] mfd: MFD_TPS65912 needs MFD_CORE Michal Marek
2013-05-07 21:41 ` Borislav Petkov
2013-05-16 22:13 ` Samuel Ortiz

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox