From: Arnd Bergmann <arnd@arndb.de>
To: Simon Horman <horms@verge.net.au>
Cc: Rob Herring <robherring2@gmail.com>,
Bastian Hecht <hechtb+renesas@gmail.com>,
Kuninori Morimoto <kuninori.morimoto.gx@renesas.com>,
"linux-arm-kernel@lists.infradead.org"
<linux-arm-kernel@lists.infradead.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH 03/21] ARM: shmobile: don't call irqchip_init unconditionally
Date: Wed, 8 May 2013 14:16:06 +0200 [thread overview]
Message-ID: <201305081416.06611.arnd@arndb.de> (raw)
In-Reply-To: <20130501225748.GD6517@verge.net.au>
On Thursday 02 May 2013, Simon Horman wrote:
> > > diff --git a/arch/arm/mach-shmobile/intc-r8a7740.c b/arch/arm/mach-shmobile/intc-r8a7740.c
> > > index 8871f77..5dc57f1 100644
> > > --- a/arch/arm/mach-shmobile/intc-r8a7740.c
> > > +++ b/arch/arm/mach-shmobile/intc-r8a7740.c
> > > @@ -53,14 +53,23 @@ static void __init r8a7740_init_irq_common(void)
> > >
> > > void __init r8a7740_init_irq_of(void)
> > > {
> > > + if (!IS_ENABLED(CONFIG_OF))
> > > + return;
> > > +
> > > irqchip_init();
> >
> > Why not have an empty irqchip_init? I'd guess we'll need this on other
> > platforms and your default mach.
>
> Thanks, I think that could work.
>
> I will see about making it so.
Ping
Linux-next is still broken for me. There is also anothe shmobile build bug,
I'll send a separate patch for that, which also needs to go into your tree.
Arnd
next prev parent reply other threads:[~2013-05-08 12:16 UTC|newest]
Thread overview: 61+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-04-25 17:28 [PATCH 00/21] more arm build fixes Arnd Bergmann
2013-04-25 17:28 ` [PATCH 01/21] ARM: topology: export cpu_topology Arnd Bergmann
2013-04-26 8:53 ` Will Deacon
2013-04-26 15:07 ` Arnd Bergmann
2013-04-25 17:28 ` [PATCH 02/21] ARM: default machine descriptor for multiplatform Arnd Bergmann
2013-04-25 17:28 ` [PATCH 03/21] ARM: shmobile: don't call irqchip_init unconditionally Arnd Bergmann
2013-04-26 0:48 ` Simon Horman
2013-04-26 8:52 ` Bastian Hecht
2013-04-29 12:58 ` [PATCH 03/21] ARM: shmobile: don't call irqchip_init unconditionallyA Arnd Bergmann
2013-04-29 14:49 ` [PATCH 03/21] ARM: shmobile: don't call irqchip_init unconditionally Arnd Bergmann
2013-04-30 1:58 ` Simon Horman
2013-04-30 2:25 ` Simon Horman
2013-05-01 15:54 ` Rob Herring
2013-05-01 22:57 ` Simon Horman
2013-05-08 12:16 ` Arnd Bergmann [this message]
2013-05-08 13:22 ` Bastian Hecht
2013-05-08 13:34 ` Arnd Bergmann
2013-05-09 3:38 ` Simon Horman
2013-05-09 4:22 ` Simon Horman
2013-04-25 17:28 ` [PATCH 04/21] ARM: orion5x: include linux/cpu.h Arnd Bergmann
2013-04-25 17:34 ` Jason Cooper
2013-04-25 18:27 ` Jason Cooper
2013-04-25 17:28 ` [PATCH 05/21] atm: he: use mdelay instead of large udelay constants Arnd Bergmann
2013-04-26 8:21 ` David Laight
2013-04-26 13:12 ` chas williams - CONTRACTOR
2013-04-29 13:13 ` [PATCH v2 05/21] atm: he: use msleep " Arnd Bergmann
2013-04-29 17:27 ` David Miller
2013-04-25 17:28 ` [PATCH 06/21] ALSA: ali5451: use mdelay " Arnd Bergmann
2013-04-26 5:40 ` Takashi Iwai
2013-04-25 17:28 ` [PATCH 07/21] oss/dmabuf: use dma_map_single Arnd Bergmann
2013-04-26 5:41 ` Takashi Iwai
2013-04-25 17:28 ` [PATCH 08/21] drm/nouveau: use mdelay instead of large udelay constants Arnd Bergmann
2013-04-25 17:28 ` [PATCH 09/21] drm: export drm_vm_open_locked Arnd Bergmann
2013-04-25 17:28 ` [PATCH 10/21] [SCSI] nsp32: use mdelay instead of large udelay constants Arnd Bergmann
2013-04-26 0:42 ` Masanori Goto
2013-04-29 13:21 ` Arnd Bergmann
2013-04-29 21:41 ` Masanori Goto
2013-05-01 13:55 ` James Bottomley
2013-04-25 17:28 ` [PATCH 11/21] irqdomain: export irq_domain_add_simple Arnd Bergmann
2013-04-26 0:50 ` Simon Horman
2013-05-31 22:37 ` Grant Likely
2013-04-25 17:28 ` [PATCH 12/21] irqchip: s3c24xx: add missing __init annotations Arnd Bergmann
2013-04-26 10:39 ` Heiko Stübner
2013-04-25 17:28 ` [PATCH 13/21] iommu: tegra: print dma_addr_t using %lld Arnd Bergmann
2013-04-25 17:42 ` Sethi Varun-B16395
2013-04-25 17:28 ` [PATCH 14/21] cpufreq: pxa2xx: initialize variables Arnd Bergmann
2013-04-25 18:14 ` Rafael J. Wysocki
2013-04-25 21:09 ` Arnd Bergmann
2013-04-25 17:28 ` [PATCH 15/21] thermal: cooling: avoid uninitialied used gcc warning Arnd Bergmann
2013-04-25 20:07 ` edubezval
2013-04-25 21:09 ` Arnd Bergmann
2013-04-26 8:10 ` Zhang Rui
2013-04-25 17:28 ` [PATCH 16/21] OF: remove #ifdef from linux/of_platform.h Arnd Bergmann
2013-04-25 17:29 ` [PATCH 17/21] X.509: do not emit any informational output Arnd Bergmann
2013-04-25 17:29 ` [PATCH 18/21] USB: ehci-msm: USB_MSM_OTG needs USB_PHY Arnd Bergmann
2013-04-25 17:59 ` Greg Kroah-Hartman
2013-04-25 21:12 ` Arnd Bergmann
2013-04-25 17:29 ` [PATCH 19/21] USB: lpc32xx: ISP1301 " Arnd Bergmann
2013-04-25 19:50 ` Roland Stigge
2013-04-25 17:29 ` [PATCH 20/21] USB: OMAP: " Arnd Bergmann
2013-04-25 17:29 ` [PATCH 21/21] USB: OHCI: avoid conflicting platform drivers Arnd Bergmann
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=201305081416.06611.arnd@arndb.de \
--to=arnd@arndb.de \
--cc=hechtb+renesas@gmail.com \
--cc=horms@verge.net.au \
--cc=kuninori.morimoto.gx@renesas.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=robherring2@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox