From: Catalin Marinas <catalin.marinas@arm.com>
To: Peter Maydell <peter.maydell@linaro.org>
Cc: Christopher Covington <cov@codeaurora.org>,
"linaro-kernel@lists.linaro.org" <linaro-kernel@lists.linaro.org>,
"patches@linaro.org" <patches@linaro.org>,
Rusty Russell <rusty@rustcorp.com.au>,
Alexander Graf <agraf@suse.de>,
"linux-kernel@vger.kernel.org List"
<linux-kernel@vger.kernel.org>, Amit Shah <amit.shah@redhat.com>,
"kvmarm@lists.cs.columbia.edu" <kvmarm@lists.cs.columbia.edu>,
"linux-arm-kernel@lists.infradead.org"
<linux-arm-kernel@lists.infradead.org>,
Pranavkumar Sawargaonkar <pranavkumar@linaro.org>
Subject: Re: [PATCH 0/2] Early printk support for virtio console devices.
Date: Wed, 8 May 2013 15:17:06 +0100 [thread overview]
Message-ID: <20130508141706.GF2703@arm.com> (raw)
In-Reply-To: <CAFEAcA-eSB=_UT0-L7o=2o6JGv0WkXZv5UPxPVqLRxjUZQegFA@mail.gmail.com>
On Tue, May 07, 2013 at 04:58:23PM +0100, Peter Maydell wrote:
> On 7 May 2013 16:52, Christopher Covington <cov@codeaurora.org> wrote:
> > On 05/07/2013 08:19 AM, Peter Maydell wrote:
> >> Well, at the moment EARLY_PRINTK is hardcoded to
> >> "use some specific UART or equivalent selected at
> >> compile time". So the equivalent presumably would
> >> be to hard-compile "use virtio-console", but then
> >> how does that code know where the virtio-console
> >> is in the address space?
> >
> > arm64 uses a kernel argument.
>
> This mixes up "information that the user provides to the
> kernel" (ie configuration) with "information that QEMU or
> kvmtool should provide to the kernel" (ie hardware
> description), and would require QEMU/kvmtool to parse
> the user's commandline tool to figure out if they
> needed to override it or edit it (or alternatively,
> would require the user to know internal details of
> QEMU/kvmtool's address map for the guest). I think it
> would be nicer to keep them separate.
I'm not sure it's worth it, the earlyprintk is meant for debugging the
early kernel booting code, not for general use (you have the normal
console for this). Someone doing platform port should know the address
of the uart and pass the right information on the kernel command line to
help debug early booting issues.
But if someone comes up with some bindings, I won't reject the patch.
--
Catalin
next prev parent reply other threads:[~2013-05-08 14:18 UTC|newest]
Thread overview: 34+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-04-26 11:04 [PATCH 0/2] Early printk support for virtio console devices Pranavkumar Sawargaonkar
2013-04-26 11:04 ` [PATCH 1/2] virtio: console: Add early writeonly register to config space Pranavkumar Sawargaonkar
2013-04-29 3:10 ` Rusty Russell
2013-04-26 11:04 ` [PATCH 2/2] arm64: earlyprintk support for virtio-mmio console Pranavkumar Sawargaonkar
2013-04-26 11:19 ` [PATCH 0/2] Early printk support for virtio console devices Alexander Graf
2013-04-26 11:33 ` Peter Maydell
2013-04-26 12:06 ` Anup Patel
2013-04-26 12:33 ` Arnd Bergmann
2013-04-26 12:59 ` Anup Patel
2013-04-26 15:03 ` Arnd Bergmann
2013-04-26 15:54 ` Marc Zyngier
2013-04-26 15:19 ` Peter Maydell
2013-04-29 3:09 ` Rusty Russell
2013-04-29 12:22 ` Alexander Graf
2013-04-29 12:48 ` Pranavkumar Sawargaonkar
2013-04-29 12:53 ` Alexander Graf
2013-05-01 2:07 ` Rusty Russell
2013-05-01 6:53 ` Anup Patel
2013-05-01 14:46 ` Will Deacon
2013-05-02 10:06 ` Peter Maydell
2013-05-06 5:11 ` Rusty Russell
2013-05-06 9:14 ` Peter Maydell
2013-05-07 4:46 ` Rusty Russell
2013-05-07 12:19 ` Peter Maydell
2013-05-07 15:52 ` Christopher Covington
2013-05-07 15:58 ` Peter Maydell
2013-05-08 14:17 ` Catalin Marinas [this message]
2013-05-09 10:39 ` Grant Likely
2013-05-06 9:40 ` Pranavkumar Sawargaonkar
2013-04-29 12:50 ` Peter Maydell
2013-04-29 12:53 ` Alexander Graf
2013-04-30 0:32 ` Rusty Russell
2013-05-01 0:26 ` Alexander Graf
2013-05-01 5:01 ` Anup Patel
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20130508141706.GF2703@arm.com \
--to=catalin.marinas@arm.com \
--cc=agraf@suse.de \
--cc=amit.shah@redhat.com \
--cc=cov@codeaurora.org \
--cc=kvmarm@lists.cs.columbia.edu \
--cc=linaro-kernel@lists.linaro.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=patches@linaro.org \
--cc=peter.maydell@linaro.org \
--cc=pranavkumar@linaro.org \
--cc=rusty@rustcorp.com.au \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox