From: Tony Lindgren <tony@atomide.com>
To: Christoph Lameter <cl@linux.com>
Cc: Chris Mason <chris.mason@fusionio.com>,
Pekka Enberg <penberg@kernel.org>,
Linus Torvalds <torvalds@linux-foundation.org>,
Andrew Morton <akpm@linux-foundation.org>,
linux-kernel@vger.kernel.org
Subject: Re: [GIT PULL] SLAB changes for v3.10
Date: Wed, 8 May 2013 12:05:34 -0700 [thread overview]
Message-ID: <20130508190534.GA32546@atomide.com> (raw)
In-Reply-To: <0000013e856463fa-9a895b58-ef76-42fa-a33d-778b89f97cf2-000000@email.amazonses.com>
* Christoph Lameter <cl@linux.com> [130508 11:31]:
> On Wed, 8 May 2013, Chris Mason wrote:
>
> > This patch fixes things for me, but to maintain the rules from
> > Christoph's patch, kmalloc_caches[2] should have been created whenever
> > kmalloc_caches[7] was done.
>
> Not necessary. The early slab bootstrap must create some slab caches of
> specific sizes, it will only use those during very early bootstrap.
>
> The later creation of the array must skip those.
>
> You correctly moved the checks out of the if (!kmalloc_cacheS())
> condition so that the caches are created properly.
>
> Acked-by: Christoph Lameter <cl@linux.com>
Great this fixes things for me too:
Acked-by: Tony Lindgren <tony@atomide.com>
next prev parent reply other threads:[~2013-05-08 19:05 UTC|newest]
Thread overview: 22+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-05-07 6:37 [GIT PULL] SLAB changes for v3.10 Pekka Enberg
2013-05-08 0:30 ` Tony Lindgren
2013-05-08 4:24 ` Tony Lindgren
2013-05-08 5:16 ` Tony Lindgren
2013-05-08 6:20 ` Pekka Enberg
2013-05-08 11:58 ` Glauber Costa
2013-05-08 12:26 ` Pekka Enberg
2013-05-08 12:38 ` Glauber Costa
2013-05-08 13:56 ` Christoph Lameter
2013-05-08 15:45 ` Tony Lindgren
[not found] ` <alpine.DEB.2.02.1305081309310.3124@gentwo.org>
2013-05-08 18:29 ` Christoph Lameter
2013-05-08 18:13 ` Chris Mason
2013-05-08 18:25 ` Christoph Lameter
2013-05-08 18:48 ` Chris Mason
2013-05-08 19:01 ` Christoph Lameter
2013-05-08 19:11 ` Tony Lindgren
2013-05-08 19:56 ` [PATCH] Fix crash during slab init Chris Mason
2013-05-08 20:10 ` Sören Brinkmann
2013-05-08 21:48 ` Tetsuo Handa
2013-05-08 22:09 ` Andrew Morton
2013-05-08 19:05 ` Tony Lindgren [this message]
2013-05-08 21:01 ` [GIT PULL] SLAB changes for v3.10 Konrad Rzeszutek Wilk
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20130508190534.GA32546@atomide.com \
--to=tony@atomide.com \
--cc=akpm@linux-foundation.org \
--cc=chris.mason@fusionio.com \
--cc=cl@linux.com \
--cc=linux-kernel@vger.kernel.org \
--cc=penberg@kernel.org \
--cc=torvalds@linux-foundation.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox