From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753148Ab3EHWM0 (ORCPT ); Wed, 8 May 2013 18:12:26 -0400 Received: from mho-03-ewr.mailhop.org ([204.13.248.66]:39593 "EHLO mho-01-ewr.mailhop.org" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1750774Ab3EHWMY (ORCPT ); Wed, 8 May 2013 18:12:24 -0400 X-Mail-Handler: Dyn Standard SMTP by Dyn X-Originating-IP: 50.131.214.131 X-Report-Abuse-To: abuse@dyndns.com (see http://www.dyndns.com/services/sendlabs/outbound_abuse.html for abuse reporting information) X-MHO-User: U2FsdGVkX1+g9H84DYQYotNlrFvkAs3F Date: Wed, 8 May 2013 15:12:22 -0700 From: Tony Lindgren To: Roger Quadros Cc: balbi@ti.com, linux-omap@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] ARM: OMAP3: Beagle: Fix USB Host on beagle xM Ax/Bx Message-ID: <20130508221221.GJ32546@atomide.com> References: <1366024808-4691-1-git-send-email-rogerq@ti.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1366024808-4691-1-git-send-email-rogerq@ti.com> User-Agent: Mutt/1.5.20 (2009-06-14) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org * Roger Quadros [130415 04:25]: > On Beagle xM Rev. Ax/Bx, the USB power enable GPIO logic is > reversed when compared to other revisions i.e. it is > active high instead of active low. > > Use the beagle_config.usb_pwr_level flag correctly so that > the power regulator can be configured at runtime. > > Signed-off-by: Roger Quadros Thanks applying into omap-for-v3.10/fixes. Regards, Tony > --- > arch/arm/mach-omap2/board-omap3beagle.c | 6 +++--- > 1 files changed, 3 insertions(+), 3 deletions(-) > > diff --git a/arch/arm/mach-omap2/board-omap3beagle.c b/arch/arm/mach-omap2/board-omap3beagle.c > index 5382215..21136b2 100644 > --- a/arch/arm/mach-omap2/board-omap3beagle.c > +++ b/arch/arm/mach-omap2/board-omap3beagle.c > @@ -112,13 +112,13 @@ static u8 omap3_beagle_version; > */ > static struct { > int mmc1_gpio_wp; > - int usb_pwr_level; > + bool usb_pwr_level; /* 0 - Active Low, 1 - Active High */ > int dvi_pd_gpio; > int usr_button_gpio; > int mmc_caps; > } beagle_config = { > .mmc1_gpio_wp = -EINVAL, > - .usb_pwr_level = GPIOF_OUT_INIT_LOW, > + .usb_pwr_level = 0, > .dvi_pd_gpio = -EINVAL, > .usr_button_gpio = 4, > .mmc_caps = MMC_CAP_4_BIT_DATA | MMC_CAP_8_BIT_DATA, > @@ -178,7 +178,7 @@ static void __init omap3_beagle_init_rev(void) > case 0: > printk(KERN_INFO "OMAP3 Beagle Rev: xM Ax/Bx\n"); > omap3_beagle_version = OMAP3BEAGLE_BOARD_XM; > - beagle_config.usb_pwr_level = GPIOF_OUT_INIT_HIGH; > + beagle_config.usb_pwr_level = 1; > beagle_config.mmc_caps &= ~MMC_CAP_8_BIT_DATA; > break; > case 2: > -- > 1.7.4.1 >