From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753493Ab3EIJdT (ORCPT ); Thu, 9 May 2013 05:33:19 -0400 Received: from mail-ee0-f49.google.com ([74.125.83.49]:57048 "EHLO mail-ee0-f49.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752232Ab3EIJc5 (ORCPT ); Thu, 9 May 2013 05:32:57 -0400 Date: Thu, 9 May 2013 11:32:53 +0200 From: Ingo Molnar To: David Ahern Cc: acme@ghostprotocols.net, linux-kernel@vger.kernel.org, Frederic Weisbecker , Peter Zijlstra , Jiri Olsa , Namhyung Kim , Stephane Eranian Subject: Re: [PATCH] perf: detect when perf.data file not closed out properly Message-ID: <20130509093253.GA21690@gmail.com> References: <1368025728-4669-1-git-send-email-dsahern@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1368025728-4669-1-git-send-email-dsahern@gmail.com> User-Agent: Mutt/1.5.21 (2010-09-15) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org * David Ahern wrote: > + pr_err("data size is 0. " > + "Was the record command properly terminated?\n"); Btw., a small stylistic request: please put user-visible strings into a single line - even if it technically turns into an overlong line. pr_err("data size is 0. Was the record command properly terminated?\n"); This 1) makes it easier for people to git grep the error text they are seeing during usage 2) makes it easier for _developers_ to see the messages they are outputing to users. For example from the single-line output it's immediately visible that it should be capitalized thusly: pr_err("Data size is 0. Was the record command properly terminated?\n"); :-) Thanks, Ingo