Re: [PATCH 18/22] mm: page allocator: Split magazine lock in two to reduce contention

Andi Kleen
2013-05-15T19:44:33Z

Mel Gorman <mgorman@suse.de> writes:
>
> -static inline struct free_area_magazine *find_lock_filled_magazine(struct zone *zone)
> +static inline struct free_magazine *find_lock_magazine(struct zone *zone)
> {
> - struct free_area_magazine *area = &zone->_noirq_magazine;
> - if (!area->nr_free)
> + int i = (raw_smp_processor_id() >> 1) & (NR_MAGAZINES-1);
> + int start = i;
> +
> + do {
> + if (spin_trylock(&zone->noirq_magazine[i].lock))
> + goto out;

I'm not sure doing it this way is great. It optimizes for lock
contention vs the initial cost of just fetching the cache line.
Doing the try lock already has to fetch the cache line, even
if the lock is contended.

Page allocation should be limited more by the cache line bouncing
than long contention

So you may be paying the fetch cost multiple times without actually
amortizing it.

If you want to do it this way I would read the lock only. That can
be much cheaper because it doesn't have to take the cache line
exclusive. It may still need to transfer it though (because another
CPU just took it exclusive), which may be already somewhat expensive.

So overall I'm not sure it's a good idea.

-Andi

--
ak@linux.intel.com -- Speaking for myself only