From: Robert Richter <rric@kernel.org>
To: Runzhen Wang <runzhen@linux.vnet.ibm.com>
Cc: Xiao Guangrong <xiaoguangrong@linux.vnet.ibm.com>,
Arnaldo Carvalho de Melo <acme@ghostprotocols.net>,
linux-kernel@vger.kernel.org, mingo@kernel.org
Subject: Re: [PATCH] perf tools: Fix perf version generation
Date: Fri, 10 May 2013 11:09:24 +0200 [thread overview]
Message-ID: <20130510090924.GB8356@rric.localhost> (raw)
In-Reply-To: <518A5A9D.8090503@linux.vnet.ibm.com>
On 08.05.13 22:01:01, Runzhen Wang wrote:
> # ./perf --version
> perf version 3.9.1
>
> your patch works when the repo only has commit info but no tags
> info, but I confuse that whether this situation is Real?
>
> Maybe you prepare for a RARE case but increase the code's **Complexity** ?
It works in both cases. And the complexity is also handled for kernel
versioning, see scripts/setlocalversion:
# If we don't have a tag at all we print -g{commitish}.
I also considered to reuse scripts/setlocalversion, but it turned out
to require too much changes for perf version generation.
-Robert
next prev parent reply other threads:[~2013-05-10 9:09 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-05-08 9:43 [PATCH] perf tools: Fix perf version generation Robert Richter
2013-05-08 10:39 ` Xiao Guangrong
2013-05-08 11:06 ` Robert Richter
2013-05-08 14:01 ` Runzhen Wang
2013-05-10 9:09 ` Robert Richter [this message]
2013-07-01 8:24 ` Borislav Petkov
2013-07-12 8:52 ` [tip:perf/urgent] " tip-bot for Robert Richter
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20130510090924.GB8356@rric.localhost \
--to=rric@kernel.org \
--cc=acme@ghostprotocols.net \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@kernel.org \
--cc=runzhen@linux.vnet.ibm.com \
--cc=xiaoguangrong@linux.vnet.ibm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox