From: Ingo Molnar <mingo@kernel.org>
To: Frederic Weisbecker <fweisbec@gmail.com>
Cc: Borislav Petkov <bp@alien8.de>, Jiri Kosina <jkosina@suse.cz>,
Tony Luck <tony.luck@intel.com>,
linux-kernel@vger.kernel.org, x86@kernel.org
Subject: Re: NOHZ: WARNING: at arch/x86/kernel/smp.c:123 native_smp_send_reschedule
Date: Fri, 10 May 2013 11:37:29 +0200 [thread overview]
Message-ID: <20130510093729.GA16487@gmail.com> (raw)
In-Reply-To: <CAFTL4hxx_pHkJExnRks4hcOYGrJb8TCMRdCtt0UA-i3wsaWWcQ@mail.gmail.com>
* Frederic Weisbecker <fweisbec@gmail.com> wrote:
> 2013/5/10 Borislav Petkov <bp@alien8.de>:
> > On Fri, May 10, 2013 at 02:29:31AM +0200, Frederic Weisbecker wrote:
> >> @@ -616,8 +616,17 @@ static bool wake_up_full_nohz_cpu(int cpu)
> >> {
> >> if (tick_nohz_full_cpu(cpu)) {
> >> if (cpu != smp_processor_id() ||
> >> - tick_nohz_tick_stopped())
> >> + tick_nohz_tick_stopped()) {
> >> + if (!cpu_online(cpu)) {
> >> + static int printed = 0;
> >> + if (!printed) {
> >> + printk("%d %d\n", cpu, smp_processor_id());
> >> + dump_stack();
> >> + printed = 1;
> >
> > You know about printk_once, right? We even have all the pr_<level>_once
> > macros.
> >
> > :-)
>
> But but that didn't fit as I also want the dump_stack(). May be we
> want dump_stack_once().
The pattern I use in such cases is:
if (WARN_ONCE(!cpu_online(cpu))) {
printk("%d %d\n", cpu, smp_processor_id());
dump_stack();
}
Thanks,
Ingo
next prev parent reply other threads:[~2013-05-10 9:37 UTC|newest]
Thread overview: 54+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-05-09 12:29 NOHZ: WARNING: at arch/x86/kernel/smp.c:123 native_smp_send_reschedule Jiri Kosina
2013-05-09 12:50 ` Borislav Petkov
2013-05-09 12:58 ` Borislav Petkov
2013-05-15 18:45 ` Paul E. McKenney
2013-05-15 22:43 ` Borislav Petkov
2013-05-15 23:55 ` Paul E. McKenney
2013-05-17 13:56 ` NOHZ: WARNING: at arch/x86/kernel/smp.c:123 native_smp_send_reschedule, round 2 Borislav Petkov
2013-05-20 3:16 ` Michael Wang
2013-05-20 4:50 ` Borislav Petkov
2013-05-20 6:23 ` Michael Wang
2013-05-20 6:47 ` Borislav Petkov
2013-05-20 6:58 ` Michael Wang
2013-05-20 7:06 ` Michael Wang
2013-05-20 7:12 ` Viresh Kumar
2013-05-20 7:25 ` Michael Wang
2013-05-20 8:56 ` Michael Wang
2013-05-20 9:09 ` Viresh Kumar
2013-05-20 9:24 ` Michael Wang
2013-05-20 13:23 ` Borislav Petkov
2013-05-20 13:43 ` Viresh Kumar
2013-05-20 15:08 ` Borislav Petkov
2013-05-21 2:20 ` Michael Wang
2013-05-21 2:37 ` Michael Wang
2013-05-21 7:21 ` Borislav Petkov
2013-05-21 7:58 ` Michael Wang
2013-05-20 7:36 ` Tejun Heo
2013-05-20 8:10 ` Frederic Weisbecker
2013-05-20 9:31 ` Srivatsa S. Bhat
2013-05-20 9:40 ` Viresh Kumar
2013-05-20 10:24 ` Viresh Kumar
2013-06-04 21:20 ` Jiri Kosina
2013-06-05 2:30 ` Michael Wang
2013-06-05 8:08 ` Jiri Kosina
2013-06-05 8:12 ` Michael Wang
2013-05-10 0:29 ` NOHZ: WARNING: at arch/x86/kernel/smp.c:123 native_smp_send_reschedule Frederic Weisbecker
2013-05-10 9:28 ` Borislav Petkov
2013-05-10 9:26 ` Frederic Weisbecker
2013-05-10 9:37 ` Ingo Molnar [this message]
2013-05-10 9:45 ` Borislav Petkov
2013-05-10 15:31 ` Frederic Weisbecker
2013-05-10 9:43 ` Borislav Petkov
2013-05-10 15:42 ` Jiri Kosina
2013-05-10 15:03 ` Jiri Kosina
2013-05-10 15:21 ` Borislav Petkov
2013-05-10 15:43 ` Frederic Weisbecker
2013-05-10 16:23 ` Borislav Petkov
2013-05-10 21:38 ` Frederic Weisbecker
2013-05-13 14:56 ` Jiri Kosina
2013-05-13 19:40 ` Thomas Gleixner
2013-05-13 20:01 ` Jiri Kosina
2013-05-14 15:46 ` [tip:timers/urgent] tick: Don't invoke tick_nohz_stop_sched_tick( ) if the cpu is offline tip-bot for Thomas Gleixner
2013-05-15 19:41 ` Frederic Weisbecker
2013-05-16 14:06 ` Thomas Gleixner
2013-05-16 14:15 ` Borislav Petkov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20130510093729.GA16487@gmail.com \
--to=mingo@kernel.org \
--cc=bp@alien8.de \
--cc=fweisbec@gmail.com \
--cc=jkosina@suse.cz \
--cc=linux-kernel@vger.kernel.org \
--cc=tony.luck@intel.com \
--cc=x86@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox