public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
From: Peter Zijlstra <peterz@infradead.org>
To: Sasha Levin <sasha.levin@oracle.com>
Cc: torvalds@linux-foundation.org, mingo@kernel.org,
	linux-kernel@vger.kernel.org
Subject: Re: [PATCH v3 2/9] liblockdep: Wrap kernel/lockdep.c to allow usage from userspace
Date: Fri, 10 May 2013 12:11:31 +0200	[thread overview]
Message-ID: <20130510101131.GA31152@dyad.programming.kicks-ass.net> (raw)
In-Reply-To: <20130510091816.GC3039@dyad.programming.kicks-ass.net>

On Fri, May 10, 2013 at 11:18:16AM +0200, Peter Zijlstra wrote:
> On Thu, May 09, 2013 at 11:58:02AM -0400, Sasha Levin wrote:
> > kernel/lockdep.c deals with validating locking scenarios for
> > various architectures supported by the kernel. There isn't
> > anything kernel specific going on in lockdep, and when we
> > compare userspace to other architectures that don't have to deal
> > with irqs such as s390, they become all too similar.
> > 
> > We wrap kernel/lockdep.c and include/linux/lockdep.h with
> > several headers which allow us to build and use lockdep from
> > userspace. We don't touch the kernel code itself which means
> > that any work done on lockdep in the kernel will automatically
> > benefit userspace lockdep as well!
> > 
> > Signed-off-by: Sasha Levin <sasha.levin@oracle.com>
> > ---
> 
> OK, this patch is a complete fail with anything not git. Please fix it so I can
> use quilt.

So I tried patch --posix; but that makes patch unhappy too:

|--- /dev/null
|+++ b/tools/lib/lockdep/Makefile
--------------------------
No file to patch.  Skipping patch.
out of 1 hunk ignored
can't find file to patch at input line 393
Perhaps you used the wrong -p or --strip option?

And while patch has a --remove-empty-files it does not recognise
--no-remove-empty-files :/

I briefly read a thread from the git mailing list where Linus and others
discussed the various weirdness around empty files and the take away was that
git would act differently by default. Because as Linus put it: "patch" is a
total piece of utterly unbelievable SH*T. 

However, aside from different behaviour I don't think its that nice git-diff
creates patches that patch cannot possibly apply right...

  parent reply	other threads:[~2013-05-10 10:13 UTC|newest]

Thread overview: 34+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-05-09 15:58 [PATCH v3 0/9] liblockdep: userspace lockdep Sasha Levin
2013-05-09 15:58 ` [PATCH v3 1/9] lockdep: Be nice about building from userspace Sasha Levin
2013-05-09 15:58 ` [PATCH v3 2/9] liblockdep: Wrap kernel/lockdep.c to allow usage " Sasha Levin
2013-05-10  9:18   ` Peter Zijlstra
2013-05-10  9:38     ` Ingo Molnar
2013-05-10 10:11     ` Peter Zijlstra [this message]
2013-05-10 13:23       ` Sasha Levin
2013-05-10 14:03         ` Peter Zijlstra
2013-05-10 14:11           ` Sasha Levin
2013-05-10 14:12             ` Peter Zijlstra
2013-05-10 14:19               ` Peter Zijlstra
2013-05-10 14:23                 ` Sasha Levin
2013-05-10 13:58   ` Peter Zijlstra
2013-05-09 15:58 ` [PATCH v3 3/9] liblockdep: Add public headers for pthread_mutex_t implementation Sasha Levin
2013-05-09 15:58 ` [PATCH v3 4/9] liblockdep: Add pthread_mutex_t test suite Sasha Levin
2013-05-09 15:58 ` [PATCH v3 5/9] liblockdep: Add public headers for pthread_rwlock_t implementation Sasha Levin
2013-05-09 15:58 ` [PATCH v3 6/9] liblockdep: Add pthread_rwlock_t test suite Sasha Levin
2013-05-09 15:58 ` [PATCH v3 7/9] liblockdep: Support using LD_PRELOAD Sasha Levin
2013-05-10 11:17   ` Peter Zijlstra
2013-05-10 11:23     ` Ingo Molnar
2013-05-10 11:46     ` Peter Zijlstra
2013-05-10 13:11       ` Peter Zijlstra
2013-05-10 13:57   ` Peter Zijlstra
2013-05-10 16:06     ` Sasha Levin
2013-05-10 16:21       ` Peter Zijlstra
2013-05-10 16:42         ` Sasha Levin
2013-05-09 15:58 ` [PATCH v3 8/9] liblockdep: Add the 'lockdep' user-space utility Sasha Levin
2013-05-10  9:19   ` Peter Zijlstra
2013-05-10  9:35     ` Ingo Molnar
2013-05-10 10:41       ` Peter Zijlstra
2013-05-10 11:00         ` Ingo Molnar
2013-05-10 11:10           ` Borislav Petkov
2013-05-10 11:07             ` Ingo Molnar
2013-05-09 15:58 ` [PATCH v3 9/9] liblockdep: Add a MAINTAINERS entry Sasha Levin

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20130510101131.GA31152@dyad.programming.kicks-ass.net \
    --to=peterz@infradead.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mingo@kernel.org \
    --cc=sasha.levin@oracle.com \
    --cc=torvalds@linux-foundation.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox