From: Peter Zijlstra <peterz@infradead.org>
To: Sasha Levin <sasha.levin@oracle.com>
Cc: torvalds@linux-foundation.org, mingo@kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH v3 2/9] liblockdep: Wrap kernel/lockdep.c to allow usage from userspace
Date: Fri, 10 May 2013 16:03:28 +0200 [thread overview]
Message-ID: <20130510140328.GC304@dyad.programming.kicks-ass.net> (raw)
In-Reply-To: <518CF4D5.4070000@oracle.com>
On Fri, May 10, 2013 at 09:23:33AM -0400, Sasha Levin wrote:
> Wait, I'm confused. Over here, patch is fine with creating empty files:
>
> lappy lockdep # touch test.c
> lappy lockdep # git diff /dev/null test.c > test.patch
> lappy lockdep # rm test.c
> lappy lockdep # file test.c
> test.c: ERROR: cannot open `test.c' (No such file or directory)
> lappy lockdep # patch -i test.patch
> patching file test.c
> lappy lockdep # file test.c
> test.c: empty
> lappy lockdep # cat test.patch
> diff --git a/tools/lib/lockdep/test.c b/tools/lib/lockdep/test.c
> new file mode 100644
> index 0000000..e69de29
> lappy lockdep #
>
> So it seems that here patch would cleanly create empty files, what does quilt
> do differently?
root@twins:~/tmp# touch ponies
root@twins:~/tmp# git diff /dev/null ponies
diff --git a/ponies b/ponies
new file mode 100644
index 0000000..e69de29
root@twins:~/tmp# git diff /dev/null ponies > ponies.patch
root@twins:~/tmp# rm ponies
root@twins:~/tmp# patch < ponies.patch
patch: **** Only garbage was found in the patch input.
t@twins:~/tmp# patch --version
patch 2.6.1
Copyright (C) 1988 Larry Wall
Copyright (C) 2003, 2009 Free Software Foundation, Inc.
This program comes with NO WARRANTY, to the extent permitted by law.
You may redistribute copies of this program
under the terms of the GNU General Public License.
For more information about these matters, see the file named COPYING.
written by Larry Wall and Paul Eggert
next prev parent reply other threads:[~2013-05-10 14:05 UTC|newest]
Thread overview: 34+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-05-09 15:58 [PATCH v3 0/9] liblockdep: userspace lockdep Sasha Levin
2013-05-09 15:58 ` [PATCH v3 1/9] lockdep: Be nice about building from userspace Sasha Levin
2013-05-09 15:58 ` [PATCH v3 2/9] liblockdep: Wrap kernel/lockdep.c to allow usage " Sasha Levin
2013-05-10 9:18 ` Peter Zijlstra
2013-05-10 9:38 ` Ingo Molnar
2013-05-10 10:11 ` Peter Zijlstra
2013-05-10 13:23 ` Sasha Levin
2013-05-10 14:03 ` Peter Zijlstra [this message]
2013-05-10 14:11 ` Sasha Levin
2013-05-10 14:12 ` Peter Zijlstra
2013-05-10 14:19 ` Peter Zijlstra
2013-05-10 14:23 ` Sasha Levin
2013-05-10 13:58 ` Peter Zijlstra
2013-05-09 15:58 ` [PATCH v3 3/9] liblockdep: Add public headers for pthread_mutex_t implementation Sasha Levin
2013-05-09 15:58 ` [PATCH v3 4/9] liblockdep: Add pthread_mutex_t test suite Sasha Levin
2013-05-09 15:58 ` [PATCH v3 5/9] liblockdep: Add public headers for pthread_rwlock_t implementation Sasha Levin
2013-05-09 15:58 ` [PATCH v3 6/9] liblockdep: Add pthread_rwlock_t test suite Sasha Levin
2013-05-09 15:58 ` [PATCH v3 7/9] liblockdep: Support using LD_PRELOAD Sasha Levin
2013-05-10 11:17 ` Peter Zijlstra
2013-05-10 11:23 ` Ingo Molnar
2013-05-10 11:46 ` Peter Zijlstra
2013-05-10 13:11 ` Peter Zijlstra
2013-05-10 13:57 ` Peter Zijlstra
2013-05-10 16:06 ` Sasha Levin
2013-05-10 16:21 ` Peter Zijlstra
2013-05-10 16:42 ` Sasha Levin
2013-05-09 15:58 ` [PATCH v3 8/9] liblockdep: Add the 'lockdep' user-space utility Sasha Levin
2013-05-10 9:19 ` Peter Zijlstra
2013-05-10 9:35 ` Ingo Molnar
2013-05-10 10:41 ` Peter Zijlstra
2013-05-10 11:00 ` Ingo Molnar
2013-05-10 11:10 ` Borislav Petkov
2013-05-10 11:07 ` Ingo Molnar
2013-05-09 15:58 ` [PATCH v3 9/9] liblockdep: Add a MAINTAINERS entry Sasha Levin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20130510140328.GC304@dyad.programming.kicks-ass.net \
--to=peterz@infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@kernel.org \
--cc=sasha.levin@oracle.com \
--cc=torvalds@linux-foundation.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox