From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1757819Ab3EKAOl (ORCPT ); Fri, 10 May 2013 20:14:41 -0400 Received: from zeniv.linux.org.uk ([195.92.253.2]:37676 "EHLO ZenIV.linux.org.uk" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1756426Ab3EKAOj (ORCPT ); Fri, 10 May 2013 20:14:39 -0400 Date: Sat, 11 May 2013 01:14:32 +0100 From: Al Viro To: "Darrick J. Wong" Cc: "Theodore Ts'o" , Andreas Dilger , "linux-fsdevel@vger.kernel.org" , linux-ext4 , linux-kernel Subject: Re: [PATCH v2] jbd2: Fix block tag checksum verification brokenness Message-ID: <20130511001432.GO25399@ZenIV.linux.org.uk> References: <20130510233807.GB5706@blackbox.djwong.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20130510233807.GB5706@blackbox.djwong.org> User-Agent: Mutt/1.5.21 (2010-09-15) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Fri, May 10, 2013 at 04:38:07PM -0700, Darrick J. Wong wrote: > Al Viro complained of a ton of bogosity with regards to the jbd2 block tag > header checksum. This one checksum is 16 bits, so cut off the upper 16 bits > and treat it as a 16-bit value and don't mess around with be32* conversions. > Fortunately metadata checksumming is still "experimental" and not in a shipping > e2fsprogs, so there should be few users affected by this. > > v2: Eliminate unnecessary variables and make it clear(er) which values are 32 > bits wide. > > Reported-by: Al Viro > Signed-off-by: Darrick J. Wong ACKed-by: Al Viro