From: Greg KH <gregkh@linuxfoundation.org>
To: Matt Kilgore <mattkilgore12@gmail.com>
Cc: devel@driverdev.osuosl.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] Staging: rtl8187se: fixed coding style issues
Date: Sun, 12 May 2013 08:33:12 -0700 [thread overview]
Message-ID: <20130512153312.GA32210@kroah.com> (raw)
In-Reply-To: <1367199093-32341-1-git-send-email-mattkilgore12@gmail.com>
On Sun, Apr 28, 2013 at 09:31:33PM -0400, Matt Kilgore wrote:
> From: Matt Kilgore <MattKilgore12@gmail.com>
>
> Fixed coding style issues with comments, braces, and spacing.
>
> Signed-off-by: Matt Kilgore <mattkilgore12@gmail.com>
> ---
> drivers/staging/rtl8187se/r8180.h | 657 +++++++++++++++++++-------------------
> 1 file changed, 325 insertions(+), 332 deletions(-)
That's a lot of changes all in one patch, making it hard to review.
Care to break this up into "only do one thing" per patch and resend it?
Probably as a few patches.
thanks,
greg k-h
next prev parent reply other threads:[~2013-05-12 15:33 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-04-29 1:31 [PATCH] Staging: rtl8187se: fixed coding style issues Matt Kilgore
2013-05-12 15:33 ` Greg KH [this message]
-- strict thread matches above, loose matches on Subject: below --
2012-11-03 23:40 [PATCH] Staging: rtl8187se: Fixed " Mladen Mijatov
2010-02-13 22:57 Gordon Mitchell
2010-02-24 0:35 ` Greg KH
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20130512153312.GA32210@kroah.com \
--to=gregkh@linuxfoundation.org \
--cc=devel@driverdev.osuosl.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mattkilgore12@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox